From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D636C2B9F4 for ; Thu, 17 Jun 2021 08:56:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C495F61245 for ; Thu, 17 Jun 2021 08:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C495F61245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 660A46B0071; Thu, 17 Jun 2021 04:55:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6106B6B0072; Thu, 17 Jun 2021 04:55:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48A3A6B0073; Thu, 17 Jun 2021 04:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 118B16B0071 for ; Thu, 17 Jun 2021 04:55:59 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A1959825EAF9 for ; Thu, 17 Jun 2021 08:55:58 +0000 (UTC) X-FDA: 78262608396.27.9AF0CFF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id B46ADA000247 for ; Thu, 17 Jun 2021 08:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=s8gPNuR5E60SDx/0jvFuG+ztKT LhkO7ekXck3IFxpaFRh0aXcx68zPSCb9j8qEojrfsBzB458A8Wpo3blG/4i9Fgwvbw3TjTMpCRW59 VDdK549e9Uj+LlQ4b0QFL2VyktYjZNBGvUW6vlpaztsCzTyyYhazCPnhn1tUZ5f4pnweFZ+zoTfcW vi3pQgHb9r1oipRjtDslyHYP3KK6c5uEA0YJ0qhlIfuVzu7oTLsvgGpZktf1hxdc8y2w+1WnpyYtm 5hFg7oBbDir+o13KteeAI+h/AHOcmJHO7kEJdITTE4WSd+WSgTmHe3mKfyx7gYxOZETR30oq6EHa1 6BJ7DQog==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnnN-008wOt-0k; Thu, 17 Jun 2021 08:54:45 +0000 Date: Thu, 17 Jun 2021 09:54:41 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210617085319.GD32587@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617085319.GD32587@quack2.suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=s8gPNuR5; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: czj9sr88jfqekdjpeafmei491a6xjiy9 X-Rspamd-Queue-Id: B46ADA000247 X-HE-Tag: 1623920148-641482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 17, 2021 at 10:53:19AM +0200, Jan Kara wrote: > On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > From: Pavel Reichl > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > state of rw_semaphores hold by inode. > > > > Looks good with the updated commit log: > > > > Signed-off-by: Christoph Hellwig > > I suppose you mean Reviewed-by, don't you? Yes: Reviewed-by: Christoph Hellwig