From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF62C48BE5 for ; Wed, 16 Jun 2021 11:47:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 16D5A6128B for ; Wed, 16 Jun 2021 11:47:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16D5A6128B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A9D76B006C; Wed, 16 Jun 2021 07:47:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 959316B006E; Wed, 16 Jun 2021 07:47:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 821786B0070; Wed, 16 Jun 2021 07:47:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 517836B006C for ; Wed, 16 Jun 2021 07:47:16 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E7E2E824999B for ; Wed, 16 Jun 2021 11:47:15 +0000 (UTC) X-FDA: 78259411230.04.73EACD2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id C3596E000261 for ; Wed, 16 Jun 2021 11:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XKAzWUGzB8MUdY5I3dCv45r+X3GXY2rgI1Q9SvG74FI=; b=upFT3Y6EMsHxlmi8HV2E5LAwgX nkRtu+HCFllCgWrpxAQ/40RgHFLJ7pKGei7X3liHxzmSpww2SsxRHwgKKZHzTEv2gHDgoDbcg4ql0 4fZUd+I5WFeqtFTWamn8kU7wz3GKEuV/LntgOWHdkAcgcVs/d41oLk1QPW8wCfTcZSHsohb9pCGz+ fbK+9fxzCNgAnILc5CtAkY7Wfq/LcKGt+/fdZf4rTyDtj32p3XlSVHRjVUgkwxrFRDPGsErNrKJcE eKL9bjt6pftr3wZ8nciCgwDA1r//vmO/TUx7HBcB84Xumq1eLmKO8HcwGSFu0/KR6WlmnKJ4kk2do YYDvECQQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltU0S-007zXc-La; Wed, 16 Jun 2021 11:47:00 +0000 Date: Wed, 16 Jun 2021 12:46:52 +0100 From: Matthew Wilcox To: David Howells Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig Subject: Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable() Message-ID: References: <20210614201435.1379188-25-willy@infradead.org> <20210614201435.1379188-1-willy@infradead.org> <815662.1623839222@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <815662.1623839222@warthog.procyon.org.uk> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C3596E000261 X-Stat-Signature: ao67mdhn3bc1uu6hwsa3oydf6baxnrg6 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=upFT3Y6E; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1623844025-15564 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 16, 2021 at 11:27:02AM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > + !folio_unevictable(folio) && folio_lru(folio)) { > > Hmmm... Would folio_lru() be better named folio_on_lru()? folio_lru() sounds > like it returns the folio's LRU. That's folio_lru_list(). It's just that we have a bad habit of saying "the lru" instead of "the lru list".