linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-mm <linux-mm@kvack.org>,
	linux-fsdevel@vger.kernel.org,
	Thomas Lindroth <thomas.lindroth@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: Possible bogus "fuse: trying to steal weird page" warning related to PG_workingset.
Date: Wed, 16 Jun 2021 13:59:31 +0100	[thread overview]
Message-ID: <YMn1s19wMQdGDQuQ@casper.infradead.org> (raw)
In-Reply-To: <CAJfpeguzkDQ5VL3m19jrepf1YjFeJ2=q99TurTX6DRpAKz+Omg@mail.gmail.com>

On Wed, Jun 16, 2021 at 02:31:32PM +0200, Miklos Szeredi wrote:
> On Mon, 14 Jun 2021 at 11:56, Thomas Lindroth <thomas.lindroth@gmail.com> wrote:
> >
> > Hi. I recently upgraded to kernel series 5.10 from 4.19 and I now get warnings like
> > this in dmesg:
> >
> > page:00000000e966ec4e refcount:1 mapcount:0 mapping:0000000000000000 index:0xd3414 pfn:0x14914a
> > flags: 0x8000000000000077(locked|referenced|uptodate|lru|active|workingset)
> > raw: 8000000000000077 ffffdc7f4d312b48 ffffdc7f452452c8 0000000000000000
> > raw: 00000000000d3414 0000000000000000 00000001ffffffff ffff8fd080123000
> > page dumped because: fuse: trying to steal weird page
> >
> > The warning in fuse_check_page() doesn't check for PG_workingset which seems to be what
> > trips the warning. I'm not entirely sure this is a bogus warning but there used to be
> > similar bogus warnings caused by a missing PG_waiters check. The PG_workingset
> > page flag was introduced in 4.20 which explains why I get the warning now.
> >
> > I only get the new warning if I do writes to a fuse fs (mergerfs) and at the same
> > time put the system under memory pressure by running many qemu VMs.
> 
> AFAICT fuse is trying to steal a pagecache page from a pipe buffer
> created by splice(2).    The page looks okay, but I have no idea what
> PG_workingset means in this context.
> 
> Matthew, can you please help?

PG_workingset was introduced by Johannes:

    mm: workingset: tell cache transitions from workingset thrashing

    Refaults happen during transitions between workingsets as well as in-place
    thrashing.  Knowing the difference between the two has a range of
    applications, including measuring the impact of memory shortage on the
    system performance, as well as the ability to smarter balance pressure
    between the filesystem cache and the swap-backed workingset.

    During workingset transitions, inactive cache refaults and pushes out
    established active cache.  When that active cache isn't stale, however,
    and also ends up refaulting, that's bonafide thrashing.

    Introduce a new page flag that tells on eviction whether the page has been
    active or not in its lifetime.  This bit is then stored in the shadow
    entry, to classify refaults as transitioning or thrashing.

so I think it's fine for you to ignore when stealing a page.


  reply	other threads:[~2021-06-16 12:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <016b2fe2-0d52-95c9-c519-40b14480587a@gmail.com>
2021-06-16 12:31 ` Miklos Szeredi
2021-06-16 12:59   ` Matthew Wilcox [this message]
2021-06-16 13:47     ` Miklos Szeredi
2021-06-16 16:48       ` Vlastimil Babka
2021-06-18 17:29         ` Johannes Weiner
2021-06-18 19:18           ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMn1s19wMQdGDQuQ@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=thomas.lindroth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox