From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5F3C2B9F4 for ; Mon, 14 Jun 2021 12:33:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E380C61206 for ; Mon, 14 Jun 2021 12:33:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E380C61206 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 79FE26B006C; Mon, 14 Jun 2021 08:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 776D56B006E; Mon, 14 Jun 2021 08:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63F496B0070; Mon, 14 Jun 2021 08:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 33FB26B006C for ; Mon, 14 Jun 2021 08:33:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A759B181AC553 for ; Mon, 14 Jun 2021 12:33:04 +0000 (UTC) X-FDA: 78252269088.28.7D31BAF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 7940040002C1 for ; Mon, 14 Jun 2021 12:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZZKvIEpsaGYUMFQ3fgpTkT5VsdH4goR4WcL96t1S438=; b=ORVU0RUBdzzZwfhSwmynH8ckhU rpBKtHq7boJ9Nileky+klBSkC8A6BeUJXRzslqfq6khT0wWC4mqzz+aZmUVfCD6lIytp1KmIPNex9 Nc7iyDeoiQY5TzwTMydnzxSImGI6Xq2ghn1vXxJDPMk7avO2vVIx8jdH4U6+pRjzXlmpcTRfvhvG6 LM4A85lnby3/xwY1LSuXpXGenWYd/6+2UdBJHfKMkLOCh5d/XB97Kx4I1y8/Q0CorvK513Obz2CLs Pawgn7oeabJGnzOzSonuhqvXdqLbySUAudKGBF2Z6SBV382kjUPkn2ZLvaq+G5jQBFTzkE4q3Xl+k nJd7c/vg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lslli-005Pl9-28; Mon, 14 Jun 2021 12:32:44 +0000 Date: Mon, 14 Jun 2021 13:32:42 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] fs: unexport __set_page_dirty Message-ID: References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614061512.3966143-2-hch@lst.de> Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ORVU0RUB; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: zr9hpkkdyzqcsskfg5e5e3xiu5c3yeer X-Rspamd-Queue-Id: 7940040002C1 X-HE-Tag: 1623673976-665231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig Reviewed-by: Matthew Wilcox (Oracle) You might also want to do the equivalent of this: https://git.infradead.org/users/willy/pagecache.git/commitdiff/19b3bf0d1a51f41ce5450fdd863969c3d32dfe12