From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8746C48BE8 for ; Mon, 14 Jun 2021 09:44:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C62061370 for ; Mon, 14 Jun 2021 09:44:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C62061370 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 047906B0072; Mon, 14 Jun 2021 05:44:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F39D16B0073; Mon, 14 Jun 2021 05:44:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB3486B0074; Mon, 14 Jun 2021 05:44:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id A68ED6B0072 for ; Mon, 14 Jun 2021 05:44:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 336538249980 for ; Mon, 14 Jun 2021 09:44:27 +0000 (UTC) X-FDA: 78251844174.28.3E1DC59 Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by imf24.hostedemail.com (Postfix) with ESMTP id 5C8B4A00024C for ; Mon, 14 Jun 2021 09:44:18 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 955AA1758; Mon, 14 Jun 2021 05:44:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 14 Jun 2021 05:44:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=k P7GTrlZ1Lv8pbIRCpbLNMCW525kd0MX52U2JVhGjrY=; b=hA3yhHVusaaIadWQi 7lPU3Pu8Li2SH9oSGCcpWN0FHq6IunJ2mZHAWMNav+jK5Q6Yj8IsUxj3dufKGhwV oFP0qJu1oU8d8xv2fKtw70cSHRngG5pVMF4oU7SiY2efLk7z7UNbEBHcdsKMTFEm AEB5FCp1dSbBnKHm5+gP8a2t8Wl6hj8XJ6+YOvu7jobQEw4+cCUKAilH9OcaS5fO Ux4NjDxI7GayEjbJHXhs/bLlKLRhoJiNbLBfRdTzdzyhiEu1kUmhkJf9XlhVv+rC AfpfBeSIHnctvPnbN5/2mbt2gr++IwRwN/WGqSEE+vfM+1yMhk750Y1EYsoCUwr4 vXJgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kP7GTrlZ1Lv8pbIRCpbLNMCW525kd0MX52U2JVhGj rY=; b=QpzupR4ZQ35Jk6Q3cWChtS2E9D3/UnZzdw0XZLZXi2++31nfvxLyn1O+Y lSuNmut0Qrikvc//ylHfNUrQB+7bG2jOQ+vdbZPeDnhAAb65P5w3v8F8Nct+6EC6 vjl4fM4MDZ8cyv4iH/wwcZIHpqkqJRDW0sgpG38+Ux7vGxFtbRVK9vOHpvwfod0+ st04M5oakWyukaEve0GIMlIu08AZ4M7TZDn14qFZ5I9bnphlykCfeSMsNzhxntXx r2z2z0onkVHSTYh5uR6L91eKoy6EzxJd8u2Lvy0JPURy8Bn6yhfZ9Qq8lYQL9qt9 YmeE/lQixrPVAfzTaIe5zkaTFR+6g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvhedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjsehtke ertddttddunecuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhm qeenucggtffrrghtthgvrhhnpeevtdeileeuteeggefgueefhfevgfdttefgtefgtddvge ejheeiuddvtdekffehffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Jun 2021 05:44:16 -0400 (EDT) Date: Mon, 14 Jun 2021 11:44:14 +0200 From: Greg KH To: sieberf@amazon.com Cc: sj38.park@gmail.com, Jonathan.Cameron@huawei.com, acme@kernel.org, akpm@linux-foundation.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, gthelen@google.com, guoju.fgj@alibaba-inc.com, linux-damon@amazon.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sjpark@amazon.de, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com Subject: Re: [PATCH v29 09/13] mm/damon/dbgfs: Support multiple contexts Message-ID: References: <20210520075629.4332-10-sj38.park@gmail.com> <98a75d0c-2d1a-807e-050b-fb8e7d92f447@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <98a75d0c-2d1a-807e-050b-fb8e7d92f447@amazon.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5C8B4A00024C Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm1 header.b=hA3yhHVu; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=QpzupR4Z; spf=pass (imf24.hostedemail.com: domain of greg@kroah.com designates 64.147.123.27 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none X-Stat-Signature: s6j77ma5g54tykp9xkp5rumbknb141g8 X-HE-Tag: 1623663858-292542 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 11:30:12AM +0200, sieberf@amazon.com wrote: > +=A0=A0=A0 new_dir =3D debugfs_create_dir(name, root); > +=A0=A0=A0 dbgfs_dirs[dbgfs_nr_ctxs] =3D new_dir; >=20 > debugfs_create_dir might return ERR_PTR, should this be checked? No. Why do you care, the logic will keep on working afterward even if that were to happen. thanks, greg k-h