From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBC8C48BCF for ; Sat, 12 Jun 2021 15:52:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF887613AD for ; Sat, 12 Jun 2021 15:52:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF887613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 167DF6B006E; Sat, 12 Jun 2021 11:52:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F0A6B0070; Sat, 12 Jun 2021 11:52:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFC016B0071; Sat, 12 Jun 2021 11:52:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id C11B56B006E for ; Sat, 12 Jun 2021 11:52:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 51117181AF5C6 for ; Sat, 12 Jun 2021 15:52:21 +0000 (UTC) X-FDA: 78245513682.09.64D5420 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id 3CFB2E000251 for ; Sat, 12 Jun 2021 15:52:16 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 16AAD610FC; Sat, 12 Jun 2021 15:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623513139; bh=/MvUw+4oP5YH+nNQUGSiupDVJ+3XAmXQq5g0t8ptRJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q1VvwNIyaBk2XHBcSAH6CgjViFyHVw7h7O3u3o2CqQwzvAsXYHdOK6k7IqY14s7bS Piy9vKBDSKe0/Yap0ZCof/B61KIZtN8W3BsYeanO+FIc4fKSBx0zqgNQFlFKeu+s53 twKvrY7G/cEgMqB2YJrA1cOrQBux8WYRy8Ye/B2Y= Date: Sat, 12 Jun 2021 17:52:17 +0200 From: Greg Kroah-Hartman To: Marco Elver Cc: Kuan-Ying Lee , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrew Morton , kasan-dev , LKML , Linux Memory Management List Subject: Re: [PATCH v2 2/3] kasan: integrate the common part of two KASAN tag-based modes Message-ID: References: <20210612045156.44763-1-kylee0686026@gmail.com> <20210612045156.44763-3-kylee0686026@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3CFB2E000251 X-Stat-Signature: zj7t4yp84b697mef7hknowh413j85g7o Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Q1VvwNIy; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf30.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-HE-Tag: 1623513136-221051 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 12, 2021 at 04:42:44PM +0200, Marco Elver wrote: > On Sat, 12 Jun 2021 at 06:52, Kuan-Ying Lee wrote: > > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > > new file mode 100644 > > index 000000000000..9c33c0ebe1d1 > > --- /dev/null > > +++ b/mm/kasan/tags.c > > @@ -0,0 +1,58 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * This file contains common tag-based KASAN code. > > + * > > + * Author: Kuan-Ying Lee > > We appreciate your work on this, but this is misleading. Because you > merely copied/moved the code, have a look what sw_tags.c says -- that > should either be preserved, or we add nothing here. > > I prefer to add nothing or the bare minimum (e.g. if the company > requires a Copyright line) for non-substantial additions because this > stuff becomes out-of-date fast and just isn't useful at all. 'git log' > is the source of truth. > > Cc'ing Greg for process advice. For moved code, does it have to > preserve the original Copyright line if there was one? Yes, it does have to. Unless you want to talk to a lot of lawyers about the issues involved here and can defend the removal of the copyright lines to them. So please keep them. Unless you can get your corporate lawyer to sign off on the patch that does the removal. thanks, greg k-h