From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A8EC47094 for ; Thu, 10 Jun 2021 14:31:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE7C0610E6 for ; Thu, 10 Jun 2021 14:31:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE7C0610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BFD26B006C; Thu, 10 Jun 2021 10:31:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 198536B006E; Thu, 10 Jun 2021 10:31:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F3E6B0070; Thu, 10 Jun 2021 10:31:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id C88CB6B006C for ; Thu, 10 Jun 2021 10:31:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 60F51180AD81F for ; Thu, 10 Jun 2021 14:31:11 +0000 (UTC) X-FDA: 78238051542.02.192BDA1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 1467080195B2 for ; Thu, 10 Jun 2021 14:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623335470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0VZTN3R2rXjD61PUqH94pStzeb8jjlq9I3l1ZVwBtoA=; b=ItVFnj/CUNeu0acbbWThhDaIJZgo4UE4tf6g5D4/4/umnYoCErGFfYCJ66jnwtUSwawj5h SDIUoKKmDNDyQnx9spK5aeq4Ix/UEPj5F1jz0HU0OOHZprjE6bS9dZjgS+73O+bnlOHE0q F2EbLq7JU5EE1qUUQ5d/xidUYgIxs1s= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-jffXSqceML2g3KN02aNSNQ-1; Thu, 10 Jun 2021 10:31:09 -0400 X-MC-Unique: jffXSqceML2g3KN02aNSNQ-1 Received: by mail-qk1-f197.google.com with SMTP id 81-20020a370e540000b02903aacdbd70b7so3011550qko.23 for ; Thu, 10 Jun 2021 07:31:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0VZTN3R2rXjD61PUqH94pStzeb8jjlq9I3l1ZVwBtoA=; b=cLIWPUSQz7KlvRWp1fnVGaXX8X+ExOF1305KfXcVOMbIilSJCfy4VmaQahKEIz4M7z Js29c3xCPduN1VdvOcDHjYGMNJCWtnpXjZb1L7BmQhaJ1wKFQyszGub3Sm6ScEkON4Zf V7r8rI6s4Ox1BOoed0y9wqJ1s3mxQzk58PLmN3GXJtQ/cTatpVHJ4A4R3DvsMKIqi1sG twz4s+DWiCZ4SYxDlQ2XzrZEpPkMmARvZRCdrZLwe7PXYpveDnDc4SDNJ3LpiXK5+Q9k w6vkFhJIoHjkp8/cyEDTVBfFSoUKssgFjcYRHJV4mEpsvwW9ixZvlJD7wEKpiudFuAYn DokQ== X-Gm-Message-State: AOAM5311XFG3CBJqtlVFsZL1uATNU7sw/uvP9La299smkT4YKqtIvZS8 LMKVZHzv3eKIK0bYhXIKL6zu4Xxy2Vbulo0+4KojjBR95VXt0JpxN725di2n9KyP0JsbvJXTOXh sAuNzzHTt0jo= X-Received: by 2002:a05:620a:142f:: with SMTP id k15mr4861069qkj.45.1623335469152; Thu, 10 Jun 2021 07:31:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaXtWdI4izo1rF2l9lVelqqAY3pjMU8ji/IWRwI5GEqoBIXP4m9XphwynSSZDXWCgmPaIwrQ== X-Received: by 2002:a05:620a:142f:: with SMTP id k15mr4861031qkj.45.1623335468800; Thu, 10 Jun 2021 07:31:08 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-88-174-93-75-200.dsl.bell.ca. [174.93.75.200]) by smtp.gmail.com with ESMTPSA id c23sm2330972qkc.3.2021.06.10.07.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 07:31:08 -0700 (PDT) Date: Thu, 10 Jun 2021 10:31:06 -0400 From: Peter Xu To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Alistair Popple , Ralph Campbell , Zi Yan , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] mm: page_vma_mapped_walk(): use pmde for *pvmw->pmd Message-ID: References: <589b358c-febc-c88e-d4c2-7834b37fa7bf@google.com> <53fbc9d-891e-46b2-cb4b-468c3b19238e@google.com> MIME-Version: 1.0 In-Reply-To: <53fbc9d-891e-46b2-cb4b-468c3b19238e@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1467080195B2 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ItVFnj/C"; spf=none (imf08.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: h4n1i6srcgtct18gj5csgkhq37ofq48x X-HE-Tag: 1623335465-908801 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 09, 2021 at 11:40:08PM -0700, Hugh Dickins wrote: > page_vma_mapped_walk() cleanup: re-evaluate pmde after taking lock, then > use it in subsequent tests, instead of repeatedly dereferencing pointer. > > Signed-off-by: Hugh Dickins > Cc: Reviewed-by: Peter Xu -- Peter Xu