From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F123C48BD1 for ; Thu, 10 Jun 2021 14:14:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 149F3613E9 for ; Thu, 10 Jun 2021 14:14:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 149F3613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DB986B006C; Thu, 10 Jun 2021 10:14:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68BE76B006E; Thu, 10 Jun 2021 10:14:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DDD46B0070; Thu, 10 Jun 2021 10:14:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 1C6356B006C for ; Thu, 10 Jun 2021 10:14:42 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B7C71180AD81F for ; Thu, 10 Jun 2021 14:14:41 +0000 (UTC) X-FDA: 78238009962.37.5156447 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id DC2CB400028D for ; Thu, 10 Jun 2021 14:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623334480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3eMUW9x1stkaG9D/YeYgpV7BE6hDJxv48nfPNnU5COg=; b=BBZQgVmDoadEXNvnBY+fDPqhyIyZh/HA2bwvrK88tlgh3O0d9wX8wcrJFWSntTgOzLx9Ge r024Dp6w/QXxnj5Sfc37vWaunTcsXKuHanw10OdjznbIiKhHL25VfPBMl1WqAl1YD2yKPw FmZHc4Y8LOjLlYXrwzkFH44D/r3Uk0s= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-bsC7TcOHOv-wPTdxapWm9A-1; Thu, 10 Jun 2021 10:14:39 -0400 X-MC-Unique: bsC7TcOHOv-wPTdxapWm9A-1 Received: by mail-qv1-f69.google.com with SMTP id k12-20020a0cfd6c0000b029020df9543019so18038444qvs.14 for ; Thu, 10 Jun 2021 07:14:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3eMUW9x1stkaG9D/YeYgpV7BE6hDJxv48nfPNnU5COg=; b=ptiE71iahX8GNbYAzthDf7CkrDER0yqexp/e3A5v/l26q+iryWiT/dwO/K+zpg1zaC b1o1GV6vTZC1J7yHmGj8UQyADUiy0wTRuhI9kUgosJm0LeDkPo/gIXuxYnxtb+r7PIyv GodxYJnP1WmtDKpLNdQFb1NPKWF+zGsNxzNAnzlAwWotVCq7UwLACCinqSa78Im1EWZu YW8TB1JMINqnM17XFze7/Q0NRVlfxHmfdiX4QBCwOC+1Wxa8a6J78+TGtZ2f3OG9a9iz UDKRr1Awcb5UJWCyH0tsH6DBaPQQmoH+pzU7F2ANk0zXZm+ixEAd/AqUuwHhNlLt1nkU fdLQ== X-Gm-Message-State: AOAM532bZDGdHdLXm6tyuQQPzm6vdZr084dFBhNdF+bDq4CnzNSfZBz2 w/SDP+A8aRuo38YgMJ2hZf/WLKWKgVRhwbOc819EYQ3NYesjY8pztthX8cjGz/ylyDs6guZvog8 UmrHi+RFbF68= X-Received: by 2002:a05:622a:2cb:: with SMTP id a11mr5297926qtx.12.1623334478936; Thu, 10 Jun 2021 07:14:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaTfyNLXhsLczTD6kzm29TcEBkes7iQLehe11xU9ySZayuTwKyb0Z1O3wF3y73of5DKgKlnQ== X-Received: by 2002:a05:622a:2cb:: with SMTP id a11mr5297900qtx.12.1623334478641; Thu, 10 Jun 2021 07:14:38 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-88-174-93-75-200.dsl.bell.ca. [174.93.75.200]) by smtp.gmail.com with ESMTPSA id s133sm2293208qke.97.2021.06.10.07.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 07:14:37 -0700 (PDT) Date: Thu, 10 Jun 2021 10:14:36 -0400 From: Peter Xu To: "Kirill A. Shutemov" Cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Alistair Popple , Ralph Campbell , Zi Yan , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] mm: page_vma_mapped_walk(): use page for pvmw->page Message-ID: References: <589b358c-febc-c88e-d4c2-7834b37fa7bf@google.com> <88e67645-f467-c279-bf5e-af4b5c6b13eb@google.com> <20210610085522.f5ffyejzn3xtqark@box.shutemov.name> MIME-Version: 1.0 In-Reply-To: <20210610085522.f5ffyejzn3xtqark@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BBZQgVmD; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: cn5s58wffth4nebpuydogouwp8h614r4 X-Rspamd-Queue-Id: DC2CB400028D X-HE-Tag: 1623334476-575217 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 10, 2021 at 11:55:22AM +0300, Kirill A. Shutemov wrote: > > @@ -234,9 +233,9 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) > > return true; > > next_pte: > > /* Seek to next pte only makes sense for THP */ > > - if (!PageTransHuge(pvmw->page) || PageHuge(pvmw->page)) > > + if (!PageTransHuge(page) || PageHuge(page)) > > return not_found(pvmw); > > - end = vma_address_end(pvmw->page, pvmw->vma); > > + end = vma_address_end(page, pvmw->vma); > > do { > > pvmw->address += PAGE_SIZE; > > if (pvmw->address >= end) > > I see two more pvmw->page in this loop. Do you leave them here as the code > will be rewritten later in the patchset? I think they've got removed in previous series ("[PATCH v2 04/10] mm/thp: fix vma_address() if virtual address below file offset"). Reviewed-by: Peter Xu -- Peter Xu