From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CA0C48BCD for ; Wed, 9 Jun 2021 15:59:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C6F461375 for ; Wed, 9 Jun 2021 15:59:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C6F461375 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9346C6B0036; Wed, 9 Jun 2021 11:59:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD186B006C; Wed, 9 Jun 2021 11:59:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E9006B0070; Wed, 9 Jun 2021 11:59:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 3D94B6B0036 for ; Wed, 9 Jun 2021 11:59:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D426A181AEF0B for ; Wed, 9 Jun 2021 15:59:56 +0000 (UTC) X-FDA: 78234646392.08.6776C49 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id AECB58019582 for ; Wed, 9 Jun 2021 15:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QFACyy0y7HrUHjJ9cPsUOZAld6dTw9TIGvy3FNUUEgI=; b=ez+gR39/yIG6DsvQX0y7KALGqu OMULMPUpfNufKUvUdlEHN9s2LEkIYgMxMfPfQeyQyt1wGMKGeUjcrWNkr7BLGGvaSSV7rC4R0cTtA byA46TmoajpBqD9QCw0smhbVGAyfuECZ9PZXPoFgfdwS4ZDlew+syrpxouv9W9pOhFcEi2ZVOfCpM Zvg1XsScqRW6Vnr1UcQMDERu1VKEejBJYgg0tsaBFC8rNIbU/TJIQvAxrAXuro5+TzC2mFXbiLv0X 89qLCoy/65c33llcaRR67OL30Tz3FXndfAlaBhPMJkPK+YIF5ltu0md10TfhTvsXYyvRXKKutc8Mq +/s34mJA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lr0bt-000fa4-Ku; Wed, 09 Jun 2021 15:59:26 +0000 Date: Wed, 9 Jun 2021 16:59:17 +0100 From: Christoph Hellwig To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com, linux-mm@kvack.org, Andrew Morton , Nicholas Piggin , Uladzislau Rezki , Catalin Marinas , Thomas Gleixner , Ingo Molnar , David Rientjes Subject: Re: [PATCH v2 1/2] mm/vmalloc: export __vmalloc_node_range Message-ID: References: <20210608180618.477766-1-imbrenda@linux.ibm.com> <20210608180618.477766-2-imbrenda@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608180618.477766-2-imbrenda@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AECB58019582 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ez+gR39/"; spf=none (imf16.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: 1k7t1bttmpyko7tu4abuh56z5j4fc8r4 X-HE-Tag: 1623254391-951300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 08, 2021 at 08:06:17PM +0200, Claudio Imbrenda wrote: > The recent patches to add support for hugepage vmalloc mappings added a > flag for __vmalloc_node_range to allow to request small pages. > This flag is not accessible when calling vmalloc, the only option is to > call directly __vmalloc_node_range, which is not exported. > > This means that a module can't vmalloc memory with small pages. > > Case in point: KVM on s390x needs to vmalloc a large area, and it needs > to be mapped with small pages, because of a hardware limitation. > > This patch exports __vmalloc_node_range so it can be used in modules > too. No. I spent a lot of effort to mak sure such a low-level API is not exported.