From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7DEC47082 for ; Sat, 5 Jun 2021 14:36:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE71D6135D for ; Sat, 5 Jun 2021 14:36:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE71D6135D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 523086B006C; Sat, 5 Jun 2021 10:36:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2AA6B006E; Sat, 5 Jun 2021 10:36:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39A596B0070; Sat, 5 Jun 2021 10:36:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 0586C6B006C for ; Sat, 5 Jun 2021 10:36:13 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8664E6D81 for ; Sat, 5 Jun 2021 14:36:13 +0000 (UTC) X-FDA: 78219920226.36.3B6FE96 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id EF239A00025D for ; Sat, 5 Jun 2021 14:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N/7FSkaz5DLbvY+hTtfMTaGpJs4YbZXAkuRXDqcjNbk=; b=aSFGGhCGnVqzEzAsFI3zM89guq 3IpZ5M4bEM5D4bU9mwWLENLgM+ZTQpZMC8idqAXu2lOpSgqkBgwVRMrxerXJ+4dqTqRs7BtyRFhAQ whup8KGeDYuEWOwYRe7+PcI11/Vc4Np/t6D9IcpsrcoD+xtDoZ5Fl7cr0mY5Ro7NRJmAToz58A5uc Cl1yY4k0JKO7uQaVHibXfuq//0n0QVJL0lY85wv1H3rjKuzecbZY2l5gYJyZCQalQKppLGIly0N5H bVS8volaV9NS6QTnAcKxqXbileQLN7YSexLXFJTKaGHHuCc8Ah+qhuERcVkC7JCarMiC3k/ATRa/o StNL96RA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lpXPA-00EA7q-5t; Sat, 05 Jun 2021 14:36:07 +0000 Date: Sat, 5 Jun 2021 15:36:04 +0100 From: Matthew Wilcox To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] mm/nommu: unexport do_munmap() Message-ID: References: <20210604194002.648037-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604194002.648037-1-Liam.Howlett@Oracle.com> Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aSFGGhCG; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EF239A00025D X-Stat-Signature: po5qenhjapqrj4pnys1igg9py99dw7q6 X-HE-Tag: 1622903771-605066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 04, 2021 at 07:40:16PM +0000, Liam Howlett wrote: > do_munmap() does not take the mmap_write_lock(). vm_munmap() should be > used instead. also, do_munmap was unexported for MMU builds back in 2012 by commit 17d1587f553d. Reviewed-by: Matthew Wilcox (Oracle) > Signed-off-by: Liam R. Howlett > --- > mm/nommu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 0997ca38c2bd..3a93d4054810 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list > delete_vma(mm, vma); > return 0; > } > -EXPORT_SYMBOL(do_munmap); > > int vm_munmap(unsigned long addr, size_t len) > { > -- > 2.30.2 >