From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC96C47082 for ; Sat, 5 Jun 2021 05:30:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D1B6613EA for ; Sat, 5 Jun 2021 05:30:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D1B6613EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C09456B006C; Sat, 5 Jun 2021 01:30:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCD856B006E; Sat, 5 Jun 2021 01:30:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A97B76B0070; Sat, 5 Jun 2021 01:30:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 7AC116B006C for ; Sat, 5 Jun 2021 01:30:16 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 20A42A2B6 for ; Sat, 5 Jun 2021 05:30:16 +0000 (UTC) X-FDA: 78218544432.08.E548757 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id F0D7920015C4 for ; Sat, 5 Jun 2021 05:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kPfCKHq5qPuRR/PUNf7xuTzUEgaFOPuNN665O2fOMb8=; b=myO+bgIXWgBFx0ToWrp8epd0iT kfK1VwZpcy51yLbEkaB4cLS8u0+vhijn5MNItIyGWP0ghJud/I3EOhRPR7NaeeNny3NZJmTsu5Ur0 728HuDF+JH506DQqNvtdknj5HjQsQ891j40UgissulFjj+Ide7LU5iBCE3n6I3tua1MY9xufPEgZU MDJYFd9lPAyFGSof9UROVj96LsIOqcFYIUkt/rand/gXFLckqJUiYzhZHn7kZ4ph4H0/OasF41z20 Po0Jy6rmSztfSkzW/hRGmGBCgZQwO2OPpx2m2eV7zrZqZqmY309QXyCc0EbCdXxdOfrWncsYkFy7w DDXtllew==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lpDq5-00DRHH-0D; Fri, 04 Jun 2021 17:42:36 +0000 Date: Fri, 4 Jun 2021 18:42:32 +0100 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] mm/thp: fix page_vma_mapped_walk() if huge page mapped by ptes Message-ID: References: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604162402.iclcdd3ywynkoamy@box.shutemov.name> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F0D7920015C4 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=myO+bgIX; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: est6h5zbgj4n5h961g7wu99ebn7k77sg X-HE-Tag: 1622871014-227871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002476, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 04, 2021 at 07:24:02PM +0300, Kirill A. Shutemov wrote: > > /* when pud is not present, pte will be NULL */ > > - pvmw->pte = huge_pte_offset(mm, pvmw->address, page_size(page)); > > + pvmw->pte = huge_pte_offset(mm, pvmw->address, > > + page_size(pvmw->page)); > > AFAICS, it exactly fits into 80-column. .. not after putting the 'pvmw->' before 'page'. > > if (!pvmw->pte) > > return false; > > > > - pvmw->ptl = huge_pte_lockptr(page_hstate(page), mm, pvmw->pte); > > + pvmw->ptl = huge_pte_lockptr(page_hstate(pvmw->page), > > + mm, pvmw->pte); > > And this one end on 79. likewise. I mean, the 'mm' could go on the previous line, but that's beyond my level of code format caring.