From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C67C07E94 for ; Fri, 4 Jun 2021 15:53:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 132296140B for ; Fri, 4 Jun 2021 15:53:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 132296140B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63D5C6B009F; Fri, 4 Jun 2021 11:53:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5ED7A6B00A1; Fri, 4 Jun 2021 11:53:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E196B00A2; Fri, 4 Jun 2021 11:53:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id 13CDF6B009F for ; Fri, 4 Jun 2021 11:53:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 95D17F02D for ; Fri, 4 Jun 2021 15:53:27 +0000 (UTC) X-FDA: 78216486054.05.C783CCA Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 5DEEE353A for ; Fri, 4 Jun 2021 15:52:54 +0000 (UTC) Received: by mail-qt1-f172.google.com with SMTP id t9so837772qtw.7 for ; Fri, 04 Jun 2021 08:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BFNJl7w5MoErGTGxa0e9M8jpquhBhJupY2y4JLWlRpA=; b=ndbmBpyRMTLo5CTZFU0wHBaAV8AcbKUUW3wG9R46rMAh3CrQ1hVUUPP25ttvbRpN5o tzg1EVk7iJYeWLL9TkNIKhnL68/IuJUA8JefbrY+j5Yr+gY+PkxpC73fwdZxDTl39brw 8VW6u1tyl9X8HLTnoUG9+DAxVN9btvcDVIFIvPX9yH9JaMAvif1QtFm7fgJOZUSJ/G7z jtDqjiWbOCcSGpQV6exeuZ7PKG5nlr5tdEj2NZJaDwDpmf2yLpkYSiEtIAHa2ia0nuTp 5seoXqQ4jqBpSjrtbSX1eEsbSnhajLDfiC3QmTj+A/RSwe+Shj4BWgpBNYpOsJmCXAWI PX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=BFNJl7w5MoErGTGxa0e9M8jpquhBhJupY2y4JLWlRpA=; b=cV7NJnpgXuMjAcd1FWlilyX5sd1EboskFsQvOjOIMn4dWUi9X9ONZGvq0pvkOa3WcN 3Q/HsOpif7Ns0Z1ONCubFKIhs7HyT90yCaJKBm3IqZKv/JfQWS05srDbBrojjvGFki24 RVzyXWcKJEMFZVWvgqYjit2jyp1C0INIY7Yqp3vVHugRiGrNLN4WzK2QHEN61KwUht/n kyKAJVpr9iqN32BvT5tMYv9zcP/LIGLXzRdEKax01CfARx5B4sCowHpNwAon8xz538/X 4n3/AGTDzG4EVGmqSIK8a9rSBY0A9V9zlp+2+Oqs2v3v0RZ9SeJm7r8FWgfz7CcYTjxI /4OQ== X-Gm-Message-State: AOAM5335/bPdBwoMpU0q1lny8eZuk9cW5zacb+FB3NBMSdsR5zetBrKC athYzhrvjbv7tffbvBPpGhk= X-Google-Smtp-Source: ABdhPJzFDKr1Iu4+DVLo0fA+2Du1paDWoFJUgPQH0szCpD4M4Al/EXPm2771IPIioqdkF1eqxM0yhQ== X-Received: by 2002:ac8:67d5:: with SMTP id r21mr5254832qtp.92.1622821983655; Fri, 04 Jun 2021 08:53:03 -0700 (PDT) Received: from localhost ([199.192.137.73]) by smtp.gmail.com with ESMTPSA id 17sm3687916qtw.44.2021.06.04.08.53.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 08:53:03 -0700 (PDT) Date: Fri, 4 Jun 2021 11:53:02 -0400 From: Tejun Heo To: Roman Gushchin Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Dennis Zhou , Dave Chinner , cgroups@vger.kernel.org Subject: Re: [PATCH v7 0/6] cgroup, blkcg: prevent dirty inodes to pin dying memory cgroups Message-ID: References: <20210604013159.3126180-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604013159.3126180-1-guro@fb.com> Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ndbmBpyR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf29.hostedemail.com: domain of htejun@gmail.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=htejun@gmail.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5DEEE353A X-Stat-Signature: zp98jqemqtbos34zt37kqwnsntkch13w X-HE-Tag: 1622821974-337624 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 03, 2021 at 06:31:53PM -0700, Roman Gushchin wrote: > To solve the problem inodes should be eventually detached from the > corresponding writeback structure. It's inefficient to do it after > every writeback completion. Instead it can be done whenever the > original memory cgroup is offlined and writeback structure is getting > killed. Scanning over a (potentially long) list of inodes and detach > them from the writeback structure can take quite some time. To avoid > scanning all inodes, attached inodes are kept on a new list (b_attached). > To make it less noticeable to a user, the scanning and switching is performed > from a work context. Sorry for chiming in late but the series looks great to me and the only comment I have is the migration target on the last patch, which isn't a critical issue. Please feel free to add Acked-by: Tejun Heo Thanks. -- tejun