From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152A2C47096 for ; Thu, 3 Jun 2021 20:04:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 878C7613FF for ; Thu, 3 Jun 2021 20:04:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 878C7613FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF9556B0036; Thu, 3 Jun 2021 16:04:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA9436B006C; Thu, 3 Jun 2021 16:04:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4A436B006E; Thu, 3 Jun 2021 16:04:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 9E77A6B0036 for ; Thu, 3 Jun 2021 16:04:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 38828180AD801 for ; Thu, 3 Jun 2021 20:04:53 +0000 (UTC) X-FDA: 78213490866.17.B6D4639 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf14.hostedemail.com (Postfix) with ESMTP id 679E5C01C08B for ; Thu, 3 Jun 2021 20:04:33 +0000 (UTC) Received: from zn.tnic (p200300ec2f13850043af4c4d530a3258.dip0.t-ipconnect.de [IPv6:2003:ec:2f13:8500:43af:4c4d:530a:3258]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3D0071EC0246; Thu, 3 Jun 2021 21:57:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622750241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=CsONDc5/hMgH+lPatsnuVGGoG9v+Dt4ffCqJHaqP7Dw=; b=PCsxWln+GSXdcrrOO6u7gyG5ZIMYDxTanA5BrUafnti30zPJ3l/VZM3cStmo9pm63XlOPN i0OuoEdNS63MBHcVvVLEGlwag2FJT9/goaw3F9mNNRb4rMA4lembyJSSyynfRpsVTfa5pe SyLuqtyEz5I8P/g3jyRufj8hoAiG288= Date: Thu, 3 Jun 2021 21:57:16 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 03/22] x86/sev: Save the negotiated GHCB version Message-ID: References: <20210602140416.23573-1-brijesh.singh@amd.com> <20210602140416.23573-4-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602140416.23573-4-brijesh.singh@amd.com> Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=PCsxWln+; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Stat-Signature: kdbd6jboexo9zxrawhdoh1qtmqwosm3w X-Rspamd-Queue-Id: 679E5C01C08B X-Rspamd-Server: rspam02 X-HE-Tag: 1622750673-142240 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 02, 2021 at 09:03:57AM -0500, Brijesh Singh wrote: > +/* > + * Since feature negotiation related variables are set early in the boot > + * process they must reside in the .data section so as not to be zeroed > + * out when the .bss section is later cleared. > + */ >From previous review: ... * * GHCB protocol version negotiated with the hypervisor. */ You need to document what this variable is used for so add a comment over it please. > +static u16 ghcb_version __section(".data"); > + -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette