From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5A4C47092 for ; Wed, 2 Jun 2021 14:25:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9CF6613BA for ; Wed, 2 Jun 2021 14:25:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9CF6613BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47C0C8E003B; Wed, 2 Jun 2021 10:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 405078E0035; Wed, 2 Jun 2021 10:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2316D8E003B; Wed, 2 Jun 2021 10:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id E094E8E0035 for ; Wed, 2 Jun 2021 10:24:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8925E180AD804 for ; Wed, 2 Jun 2021 14:24:59 +0000 (UTC) X-FDA: 78209005518.10.AD07E0B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id A2E01A00026D for ; Wed, 2 Jun 2021 14:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FXtOoRkqKzh7kLJLNx1aUNoAKOt2OwhOUmVlEeFOV/k=; b=aRuCf7uzTZTu6Zoj/CNNkrWz2p NiTO7Wp3c1qPbyOpXwrYp1PtzDWjm9lFd/a9yCbHrEoTHdjq7a3h6AyF0BhDXTQ3QxkDP57PRhMDO zEAZMYNvsYz4QiZA1N4mjgb4wXj7bSBZgp8Pj/xrfNSCm3M3p7yfnXQJFAELoJtdR+E6Ao31ANWBK 327hKxLUv5HjbIqhiob98T4BjpKz+Vu+QWE82pAMH8ZWHQCaLUEhWPpOLHq5XbviYzak8e7g6jAgm AiylRMwPRrr6GP8fi1UzCBGjGo3iWRRsemSjXVXxNvj6tuH5bjajvu6yIt+A7WLPb35t2K8sXA42g 5gfHi5dg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1loRmn-00BCUs-DM; Wed, 02 Jun 2021 14:24:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D1C23300269; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B6EF620223DA8; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Date: Wed, 2 Jun 2021 16:23:56 +0200 From: Peter Zijlstra To: Mathieu Desnoyers Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , acme , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , paulmck , Josh Triplett , Lai Jiangshan , "Joel Fernandes, Google" , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel , linux-block@vger.kernel.org, netdev , linux-usb@vger.kernel.org, linux-fsdevel , cgroups , kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu , linux-mm , KVM list Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition Message-ID: References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aRuCf7uz; spf=none (imf15.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A2E01A00026D X-Stat-Signature: 3g6c88rq33sgee959a1ue8jefamjkps8 X-HE-Tag: 1622643891-571585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 02, 2021 at 10:15:16AM -0400, Mathieu Desnoyers wrote: > ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: > [...] > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > > }, > > }; > > > > - if (!sched_in && task->state == TASK_RUNNING) > > + if (!sched_in && current->on_rq) { > > switch_event.event_id.header.misc |= > > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > > + } > > > > - perf_iterate_sb(perf_event_switch_output, > > - &switch_event, > > - NULL); > > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > > } > > There is a lot of code cleanup going on here which does not seem to belong > to a "Fix" patch. Maybe, but I so hate whitespace only patches :-/