From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EA1C47080 for ; Tue, 1 Jun 2021 10:30:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93C516139A for ; Tue, 1 Jun 2021 10:30:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93C516139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F330D6B00B0; Tue, 1 Jun 2021 06:30:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE33A6B00B2; Tue, 1 Jun 2021 06:30:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAAC36B00B3; Tue, 1 Jun 2021 06:30:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 950896B00B0 for ; Tue, 1 Jun 2021 06:30:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0864B181AEF10 for ; Tue, 1 Jun 2021 10:30:07 +0000 (UTC) X-FDA: 78204784854.22.F43B3A3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP id 7596F600056E for ; Tue, 1 Jun 2021 10:29:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2952A6139A; Tue, 1 Jun 2021 10:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622543405; bh=kNAwLTC/vYzJzA7/OMnucxDZFPGz19LT0a5jL1f44lI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZfWrQ4xU5t4rNRZGYcTmWiq/f4QjWfNpaG/etiMivb8+dEWpYrx//MIO4lGjHFR71 AYJw+hi0eK61uZmTKiShHFN0RZ1lqyP1MFWNmkV+RigeKXzqXw56KTy8CdqmDTqV0E t56eZ5hq2l7owkxSi+tjzYnXzCNJXDKwlkFYqQss= Date: Tue, 1 Jun 2021 12:30:03 +0200 From: Greg KH To: Faiyaz Mohammed Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, glittao@gmail.com, vinmenon@codeaurora.org Subject: Re: [PATCH v8] mm: slub: move sysfs slab alloc/free interfaces to debugfs Message-ID: References: <1622542057-14632-1-git-send-email-faiyazm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622542057-14632-1-git-send-email-faiyazm@codeaurora.org> Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ZfWrQ4xU; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf09.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7596F600056E X-Stat-Signature: bkizph38b6i1piiihhm8sku1d6bkgtrn X-HE-Tag: 1622543399-86588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 01, 2021 at 03:37:37PM +0530, Faiyaz Mohammed wrote: > alloc_calls and free_calls implementation in sysfs have two issues, > one is PAGE_SIZE limitiation of sysfs and other is it does not adhere > to "one value per file" rule. > > To overcome this issues, move the alloc_calls and free_calls implemeation > to debugfs. > > Debugfs cache will be created if SLAB_STORE_USER flag is set. > > Rename the alloc_calls/free_calls to alloc_traces/free_traces, > to be inline with what it does. > > Signed-off-by: Faiyaz Mohammed Reviewed-by: Greg Kroah-Hartman