From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EB44C47082 for ; Mon, 7 Jun 2021 15:35:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C9F6060FF1 for ; Mon, 7 Jun 2021 15:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F6060FF1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F2CF6B0036; Mon, 7 Jun 2021 11:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2F76B006E; Mon, 7 Jun 2021 11:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41DD56B0070; Mon, 7 Jun 2021 11:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 107ED6B0036 for ; Mon, 7 Jun 2021 11:35:32 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EBCEBA0A for ; Mon, 7 Jun 2021 15:35:31 +0000 (UTC) X-FDA: 78227327262.38.EAC786F Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf30.hostedemail.com (Postfix) with ESMTP id E7648E000276 for ; Mon, 7 Jun 2021 15:35:23 +0000 (UTC) Received: from zn.tnic (p200300ec2f0b4f0010db370b6947fb68.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:4f00:10db:370b:6947:fb68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8578E1EC04CD; Mon, 7 Jun 2021 17:35:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1623080123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=qFFCUAag8UGkqculjLWLlTiPg+uQkNT3QZ7+KscRBoA=; b=BKOlmEeKnyk5qxENdyy79PSCLvCjmvXOE3iQHPkpjK6gxXcWlNFo/wsR2nw6WKnGPIKhy6 Xp7JRpoEaS1wiqjd6hKFwKKCHs38CLT81t6M/lommh1TMic1r+Q4KOhijQhUK6/yA0qzCE CojhJDDtfzCf0hsxub2W1TXpqykEBFM= Date: Mon, 7 Jun 2021 17:35:18 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , tony.luck@intel.com, npmccallum@redhat.com Subject: Re: [PATCH Part1 RFC v3 07/22] x86/sev: Add a helper for the PVALIDATE instruction Message-ID: References: <20210602140416.23573-1-brijesh.singh@amd.com> <20210602140416.23573-8-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210602140416.23573-8-brijesh.singh@amd.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E7648E000276 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=BKOlmEeK; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de X-Stat-Signature: yq9tch78s99ck5cnjr9rz4nn5ukbds8x X-HE-Tag: 1623080123-511081 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 02, 2021 at 09:04:01AM -0500, Brijesh Singh wrote: > +static inline int pvalidate(unsigned long vaddr, bool rmp_psize, bool validate) > +{ > + bool no_rmpupdate; > + int rc; >From a previous review: Please put over the opcode bytes line: /* "pvalidate" mnemonic support in binutils 2.36 and newer */ > + asm volatile(".byte 0xF2, 0x0F, 0x01, 0xFF\n\t" > + CC_SET(c) > + : CC_OUT(c) (no_rmpupdate), "=a"(rc) > + : "a"(vaddr), "c"(rmp_psize), "d"(validate) > + : "memory", "cc"); > + > + if (no_rmpupdate) > + return PVALIDATE_FAIL_NOUPDATE; > + > + return rc; > +} -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette