From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DBAC2B9F8 for ; Tue, 25 May 2021 10:33:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51915613F4 for ; Tue, 25 May 2021 10:33:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51915613F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A009E6B006C; Tue, 25 May 2021 06:33:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D8E36B006E; Tue, 25 May 2021 06:33:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F776B0070; Tue, 25 May 2021 06:33:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 5A4C26B006C for ; Tue, 25 May 2021 06:33:36 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EE749180ACF76 for ; Tue, 25 May 2021 10:33:35 +0000 (UTC) X-FDA: 78179391990.36.85AFEBB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id 8604190009EA for ; Tue, 25 May 2021 10:33:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D279A6135F; Tue, 25 May 2021 10:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621938814; bh=Ko9OW2xC/ai6cW5nxuzYSepYUMdmcDhImMaQHNUt4GU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u4RVyL+7FSjZtsX7r9rxHtTCssZ+FSunKqJIhJTzaw8YlvWznlde3vYlfZbIpF60m yQgFbMSALJNlefBsKkLBKrzgThn/6zIZcqK4MbbsPwRok5/2bSGiEt+IwKBlJk9fe0 CeUrgp0qwWudZozH9zxIpl24wuAJ449j9aEzd5ZGLSqYjZQuwgFl4yGNc0Rf9fS0mn XMs9GjkBQjMYHJLlrG8URw36vTGYy3Kl1SDfM1dRj/G0p9LPGlFeXQkZQGkQhDZJOL nzMwdabh+bzX1ZruB+J2ISA2Y6nt32ZI4AFKzptaMitsiVSzduIGXGXsSC/fxJ75jy tSKHsaVQvjVdg== Date: Tue, 25 May 2021 13:33:26 +0300 From: Mike Rapoport To: Randy Dunlap Cc: linux-mm@kvack.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org, Andrew Morton , Nanyong Sun Subject: Re: [PATCH -next] riscv: TRANSPARENT_HUGEPAGE: depends on MMU Message-ID: References: <20210525001302.27779-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210525001302.27779-1-rdunlap@infradead.org> X-Rspamd-Queue-Id: 8604190009EA Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u4RVyL+7; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam04 X-Stat-Signature: jxitxap334wz5wf8wp3gqkaagqwrpzgh X-HE-Tag: 1621938808-227150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 24, 2021 at 05:13:02PM -0700, Randy Dunlap wrote: > Fix a Kconfig warning and many build errors: > > WARNING: unmet direct dependencies detected for COMPACTION > Depends on [n]: MMU [=n] > Selected by [y]: > - TRANSPARENT_HUGEPAGE [=y] && HAVE_ARCH_TRANSPARENT_HUGEPAGE [=y] > > and the subseqent thousands of build errors and warnings. > > Fixes: e88b333142e4 ("riscv: mm: add THP support on 64-bit") > Signed-off-by: Randy Dunlap > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: linux-riscv@lists.infradead.org > Cc: Andrew Morton > Cc: Nanyong Sun Acked-by: Mike Rapoport > --- > I really think that mm/Kconfig should have "depends on MMU" for > TRANSPARENT_HUGEPAGE, but commit 15626062f4a9 from 2012 > ("thp, x86: introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE") thought > differently. I.e., mm/Kconfig should be protecting all arches > against this Kconfig problem. We could diff --git a/mm/Kconfig b/mm/Kconfig index 02d44e3420f5..85bc8bf32e7b 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -403,7 +403,7 @@ config NOMMU_INITIAL_TRIM_EXCESS config TRANSPARENT_HUGEPAGE bool "Transparent Hugepage Support" - depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE + depends on MMU && HAVE_ARCH_TRANSPARENT_HUGEPAGE select COMPACTION select XARRAY_MULTI help but in a sense HAVE_ARCH_TRANSPARENT_HUGEPAGE should imply that MMU is selected :) > arch/riscv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20210524.orig/arch/riscv/Kconfig > +++ linux-next-20210524/arch/riscv/Kconfig > @@ -106,7 +106,7 @@ config RISCV > select SYSCTL_EXCEPTION_TRACE > select THREAD_INFO_IN_TASK > select UACCESS_MEMCPY if !MMU > - select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT > + select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT && MMU > > config ARCH_MMAP_RND_BITS_MIN > default 18 if 64BIT > -- Sincerely yours, Mike.