From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08EF4C433B4 for ; Fri, 21 May 2021 11:47:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6FC98613DA for ; Fri, 21 May 2021 11:47:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC98613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC6B58E0036; Fri, 21 May 2021 07:47:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D75E98E0022; Fri, 21 May 2021 07:47:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3D8F8E0036; Fri, 21 May 2021 07:47:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 937378E0022 for ; Fri, 21 May 2021 07:47:36 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2AE0F181AEF3E for ; Fri, 21 May 2021 11:47:36 +0000 (UTC) X-FDA: 78165063312.26.2FC67BB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 017B620007FD for ; Fri, 21 May 2021 11:47:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7zi9Mu6WcsowR0XFLEPxmhm73QEFbxhQlh8Qiw0zCGA=; b=DQJS4wmrZMw88UhIzP8UpdE5Zt oENnC+faFOhr3f/cC+vrqBpwZ8by5m4fC5aiIzZ4HTBC18hjY7ptrH9T0z9nNzEnbrRuM73O1T1vF OHYGQTk6mzITPIASr5FgiKlzbGD4UhEZ82fyxowZ9YgtQLepwJfPyIUpJd1vTfWvKrxoIFMQySP8o vmaCISID4N+eXhyHEWAO5S4Ppppw9Ny5ytz0S3cP9Iqt2iCU1ayquCH0KLQs9wkTYUI+3SLHDWOza 1ZEuarvxhfpal02MJtOLlqD7uR98O8Oww2jl89vZjoOxymT3LZ8HJmtoB665Y0X7HTS9yAHsYTBgz FBRs/1XA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lk3YX-00GvKt-G6; Fri, 21 May 2021 11:43:37 +0000 Date: Fri, 21 May 2021 12:43:05 +0100 From: Matthew Wilcox To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Mel Gorman , Christoph Hellwig , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH] mm/vmalloc: Fallback to a single page allocator Message-ID: References: <20210521111033.2243-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521111033.2243-1-urezki@gmail.com> Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DQJS4wmr; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: r3j9zn697ijggoexzyxaq9ppfechrzu4 X-Rspamd-Queue-Id: 017B620007FD X-Rspamd-Server: rspam02 X-HE-Tag: 1621597652-577649 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 21, 2021 at 01:10:33PM +0200, Uladzislau Rezki (Sony) wrote: > +static inline unsigned int > +vm_area_alloc_pages(gfp_t gfp, int nid, unsigned int page_order, > + unsigned long nr_small_pages, struct page **pages) (at least) two tabs here, please, otherwise the argument list is at the same indentation as the code which trips up my parser. some people like to match the opening bracket, but that always feels like more work than it's worth. fwiw, i'd format it like this: static inline unsigned int vm_area_alloc_pages(gfp_t gfp, int nid, unsigned int order, unsigned long nr_pages, struct page **pages) { ... (yes, i renamed some of the variables there; overly long variable names are painful) The rest of the patch looks good. Reviewed-by: Matthew Wilcox (Oracle)