From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2FAC433ED for ; Thu, 20 May 2021 23:24:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71A06613B4 for ; Thu, 20 May 2021 23:24:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71A06613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE93A6B011D; Thu, 20 May 2021 19:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC0816B011E; Thu, 20 May 2021 19:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62E16B011F; Thu, 20 May 2021 19:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id A350A6B011D for ; Thu, 20 May 2021 19:24:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4B110180AD801 for ; Thu, 20 May 2021 23:24:24 +0000 (UTC) X-FDA: 78163190448.12.C334201 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 11194C0042C0 for ; Thu, 20 May 2021 23:24:21 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id z85-20020a1c7e580000b029017a76f3afbaso3608924wmc.2 for ; Thu, 20 May 2021 16:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=99Is1Ox+Utl3amtJ0W3WXbULjI/XXbGGwaImoB8VLO0=; b=SBhG7LJdDG6oVaDdeb1V/wPcz2OpmKfA0emiiCx8sx7w7QGGe+nk2Gbui8dplk3ueG JCAs/hx4f7hpDdW1E8Ycp+FbSStIqraiwdWD9CyXXvW3T4mu1RQWok0sn24AeMKWT0HP 9ObBbfleQHRmT9vl8GHFsOlCtoDtGn8WdgZSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=99Is1Ox+Utl3amtJ0W3WXbULjI/XXbGGwaImoB8VLO0=; b=NpF4BuIAXYXqltLeitscVD6RYcJf/UQqsg+3/GMH0eHzhkUioTM87uSMR1AmGx+kv8 YHf0Vhh53XzzksTjdrJC1m+yz0EcKYnCGZBo22jF6LHKzoc50daPPIoyEa4hFrUBe/jX ZLypO+ynjG8W0ThvSMuBNXngQa5gNhQ8JnZ/mlW/L5WUAH45pILOsc1Pf73bwxDAkZX/ IjFOsIRg1Pve0m6XlIdLxpBXZzoUgh3NDZiGBp/0UB93eR/sdcWW7Zd0iCKjpH7TQE66 qgEZDOTpcrWl/50fdhyk3GDDiXE8l20W0/aW7VqovjG9xYHTvQXLy1itXx5MxMHq7m5h KX8w== X-Gm-Message-State: AOAM531obP8zMN8H4Z6Cro2vV/+NWzFv8FhL43WW7dyfO00o6sEVGGBo fyJ7HJObNAT6nBrFTygkDPlMmA== X-Google-Smtp-Source: ABdhPJzk8F30NdHe2UWtkK774YOUN3SDUCB55L0lserV+HcNqSqQASa3kV1OPxlNWZf5JhIfJWjf3g== X-Received: by 2002:a05:600c:4fd6:: with SMTP id o22mr5693192wmq.83.1621553062636; Thu, 20 May 2021 16:24:22 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:ab33]) by smtp.gmail.com with ESMTPSA id f188sm10606713wmf.24.2021.05.20.16.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 16:24:22 -0700 (PDT) Date: Fri, 21 May 2021 00:24:21 +0100 From: Chris Down To: Mel Gorman Cc: Andrew Morton , Michal Hocko , David Hildenbrand , Vlastimil Babka , Dan Streetman , Yang Shi , Linux-MM , LKML Subject: Re: [PATCH 06/14] mm/memcontrol.c: Fix kerneldoc comment for mem_cgroup_calculate_protection Message-ID: References: <20210520084809.8576-1-mgorman@techsingularity.net> <20210520084809.8576-7-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210520084809.8576-7-mgorman@techsingularity.net> User-Agent: Mutt/2.0.7 (481f3800) (2021-05-04) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=SBhG7LJd; dmarc=pass (policy=none) header.from=chrisdown.name; spf=pass (imf03.hostedemail.com: domain of chris@chrisdown.name designates 209.85.128.47 as permitted sender) smtp.mailfrom=chris@chrisdown.name X-Stat-Signature: 1wu78m1gn46i8bebb98j94tdz4acp1sj X-Rspamd-Queue-Id: 11194C0042C0 X-Rspamd-Server: rspam02 X-HE-Tag: 1621553061-811836 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mel Gorman writes: >make W=1 generates the following warning for mem_cgroup_calculate_protection > > mm/memcontrol.c:6468: warning: expecting prototype for mem_cgroup_protected(). Prototype was for mem_cgroup_calculate_protection() instead > >Commit 45c7f7e1ef17 ("mm, memcg: decouple e{low,min} state mutations from >protection checks") changed the function definition but not the associated >kerneldoc comment. > >Fixes: 45c7f7e1ef17 ("mm, memcg: decouple e{low,min} state mutations from protection checks") >Signed-off-by: Mel Gorman Whoops, thanks. Acked-by: Chris Down >--- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 64ada9e650a5..030c1dc131ce 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -6456,7 +6456,7 @@ static unsigned long effective_protection(unsigned long usage, > } > > /** >- * mem_cgroup_protected - check if memory consumption is in the normal range >+ * mem_cgroup_calculate_protection - check if memory consumption is in the normal range > * @root: the top ancestor of the sub-tree being checked > * @memcg: the memory cgroup to check > * >-- >2.26.2 > >