From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5066AC433B4 for ; Thu, 20 May 2021 19:20:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A45C61363 for ; Thu, 20 May 2021 19:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A45C61363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D882B6B00AD; Thu, 20 May 2021 15:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D10CA6B00AE; Thu, 20 May 2021 15:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B897A8E001B; Thu, 20 May 2021 15:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id 8294E6B00AD for ; Thu, 20 May 2021 15:19:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2CB4ABBC3 for ; Thu, 20 May 2021 19:19:59 +0000 (UTC) X-FDA: 78162574518.05.AC3136D Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf04.hostedemail.com (Postfix) with ESMTP id D8D2A2C8 for ; Thu, 20 May 2021 19:19:57 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id lx17-20020a17090b4b11b029015f3b32b8dbso4217131pjb.0 for ; Thu, 20 May 2021 12:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sAQXDqHg+QqOGKOJDjzmLWV7mdQnspavEi3kfD9gWIQ=; b=LcLMvABXBv5ssd8bBL16v2rmmU6poAzb8jnXwjRqhVULOejJ17dTRYHjQ95sldLyhQ EDkVbm00GBaTsS1JMySlM1Sz/N+3xFfJCW+K2MdrAiP1C7ZEqVSgfjQGsP2yoXYqefhf qE0fuyqYkKwH3gsADK+p96u9ltd4jRqp5G5R4O/RfdXCKQWnLBRJbneh2aw/23DVqSDM ClNy1kR62nD0QmugvWd+ViPAs+fJtH8rMijXVsgWA7RwEyv14PbpBBEyh9RKcP5NYP3c 1nwjYIZ7A95sb+jMJlAaMvInQuxpsOFTwknCyXzdXZAu4c5NMELQIaAkLx811v7/h9lT 6d+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=sAQXDqHg+QqOGKOJDjzmLWV7mdQnspavEi3kfD9gWIQ=; b=uVVPcthAAbzEh0WaI05VZg1tUHFIxM0utRZ9hiq0rKjBbDF6mN3jCK1zqXY6SSd8D5 sf5AXXVZBSskIc4cnc5xJUk6nkvNJxE8LeidEbX9jDGiVkCrX9uYgWdrnO5G8H6CxFp2 iTdzJ0ThtsfO4faVSZUeL2vYgXzycjEsfvQTHRo1jn5WGSccWp8qLmQuPbduWpXOjTaw nBmny3On/dDv4L/I+xvr5/qP13dDsYlr5ieXWEQN0jeHSulPJMTckADCJeR7at6Z+vsA 0yAdF/QJGZPcWBA6EpsLriehqssfmDYdw+i4PgjLXSYtlN2M/J/FFpl+ZfGoYgAO1q8t x7zw== X-Gm-Message-State: AOAM533wxY9Z4iD7ANlD+IHNJf7jllZazkexGuUqszOUckjPmo7Pc2hK Hiir9Nz2wJSnllY3I5qYb6E= X-Google-Smtp-Source: ABdhPJyYIIyIs0/OH0gsyJGAd3roUCX7k/v+yE4krIf+WxGBQ1evaiaQo8bj/Av86C7pt3cd20qAOw== X-Received: by 2002:a17:90b:201:: with SMTP id fy1mr6755194pjb.119.1621538397947; Thu, 20 May 2021 12:19:57 -0700 (PDT) Received: from google.com ([2620:15c:211:201:f248:e9e3:9874:9116]) by smtp.gmail.com with ESMTPSA id c9sm2461371pfl.169.2021.05.20.12.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 12:19:57 -0700 (PDT) Date: Thu, 20 May 2021 12:19:55 -0700 From: Minchan Kim To: Andrew Morton Cc: Suren Baghdasaryan , John Dias , Michal Hocko , David Hildenbrand , LKML , linux-mm Subject: Re: [PATCH] mm: page_alloc: dump migrate-failed pages only at -EBUSY Message-ID: References: <20210519213341.2620708-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519213341.2620708-1-minchan@kernel.org> X-Rspamd-Queue-Id: D8D2A2C8 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=LcLMvABX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf04.hostedemail.com: domain of minchankim@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=minchankim@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: oitgpo3edgexsc98ubtj4fhu6kggdhxf X-HE-Tag: 1621538397-311125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 19, 2021 at 02:33:41PM -0700, Minchan Kim wrote: > alloc_contig_dump_pages aims for helping debugging page migration > failure by page refcount mismatch or something else of page itself > from migration handler function. However, in -ENOMEM case, there is > nothing to get clue from page descriptor information so just > dump pages only when -EBUSY happens. > > Signed-off-by: Minchan Kim > --- > mm/page_alloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3100fcb08500..c0a2971dc755 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8760,7 +8760,8 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, > > lru_cache_enable(); > if (ret < 0) { > - alloc_contig_dump_pages(&cc->migratepages); > + if (ret == -EBUSY) > + alloc_contig_dump_pages(&cc->migratepages); > putback_movable_pages(&cc->migratepages); > return ret; > } > -- > 2.31.1.751.gd2f1c929bd-goog > Resend with a little modifying description. >From c5a2fea291cf46079b87cc9ac9a25fc7f819d0fd Mon Sep 17 00:00:00 2001 From: Minchan Kim Date: Wed, 19 May 2021 14:22:18 -0700 Subject: [PATCH] mm: page_alloc: dump migrate-failed pages only at -EBUSY alloc_contig_dump_pages aims for helping debugging page migration failure by elevated page refcount compared to expected_count. (for the detail, please look at migrate_page_move_mapping) However, -ENOMEM is just the case that system is under memory pressure state, not relevant with page refcount at all. Thus, the dumping page list is not helpful for the debugging point of view. Signed-off-by: Minchan Kim --- mm/page_alloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3100fcb08500..c0a2971dc755 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8760,7 +8760,8 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, lru_cache_enable(); if (ret < 0) { - alloc_contig_dump_pages(&cc->migratepages); + if (ret == -EBUSY) + alloc_contig_dump_pages(&cc->migratepages); putback_movable_pages(&cc->migratepages); return ret; } -- 2.31.1.818.g46aad6cb9e-goog