From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBC0C433ED for ; Thu, 20 May 2021 12:46:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56B9F61001 for ; Thu, 20 May 2021 12:46:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56B9F61001 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFAFF8E0007; Thu, 20 May 2021 08:46:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD1F08E0006; Thu, 20 May 2021 08:46:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B35D88E0007; Thu, 20 May 2021 08:46:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 7DE068E0006 for ; Thu, 20 May 2021 08:46:42 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1D1F2DB30 for ; Thu, 20 May 2021 12:46:42 +0000 (UTC) X-FDA: 78161583444.27.DF61D7D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 02C27A0001CD for ; Thu, 20 May 2021 12:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621514801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e4Fywv1ENiQVYa4wbDxfInSTJhNzcF1YbxHx9cQFq/I=; b=d4QuOougWAhbhCRx2V2EGZmoEh8sL+QdswEkKYCFuwAxL/Wk/BsCJMDW04O+lK1qYpSANX WCjunSKn7tSJ6dC9nVweVtPs11yXtBE4T8WqAi/u1t/tuzoNddLjJD3rZSzGBv8lkeqehb //VyohoD5Fe4oiLBZIojw6AB9UtdL4Q= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-OPvfYyK8OiugGKeYCRDhrA-1; Thu, 20 May 2021 08:46:39 -0400 X-MC-Unique: OPvfYyK8OiugGKeYCRDhrA-1 Received: by mail-qk1-f199.google.com with SMTP id z2-20020a3765020000b02903a5f51b1c74so1323995qkb.7 for ; Thu, 20 May 2021 05:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e4Fywv1ENiQVYa4wbDxfInSTJhNzcF1YbxHx9cQFq/I=; b=UGPT00Aig1X0JZu8Gq0g7yY9jcHiCoY9j3ccyrckQfY7ROC7NeXj9sfARdGJe/zt3E lhyfdrJpt5IsEh5RQoDxGX5EVNpfoZVvXZAPVmGXv4vtg1ZyNIA3QnsMaDvIf24PeVnI D6+OVsxBtXUIiaGh5I5BIMbaYA7gjKSB5YNZY5lE0qJZpM7Vsr8XKlJ0344m2+yWh+Es fjUC9taOkvureVeTUCFb75V8+Bc3IJ3J7PKPQkeIU7Pd3ylKEm3wApuFmSLzk0u2M1T5 2hAcwHZKRhOWqlCjjkd78Us34a4wUt+qFmIaaaJYVFojHb7CdDXaPuj3j+oBleKvyE9p 274A== X-Gm-Message-State: AOAM532ZhejPobxBBnwjwg3nap8coiZHigj47YcRmFs9TEwSv5nKSObD SY+A6id96NTYDkJDPj5XVtQK034gajGlqh4vkQvpTefqHCa0VBzxxBIbJ/2ao2rt3y3Ccg9ZC2H UeTor/H+J7z8= X-Received: by 2002:a0c:a9db:: with SMTP id c27mr5484599qvb.50.1621514799222; Thu, 20 May 2021 05:46:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykH36WPuvRGC1ihzQ0iEIBjEHESz262HbbXiVKUFg4El15AaxsQh3dm6Y8Q9wTut0JQgl2Mg== X-Received: by 2002:a0c:a9db:: with SMTP id c27mr5484570qvb.50.1621514798898; Thu, 20 May 2021 05:46:38 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-72-184-145-4-219.dsl.bell.ca. [184.145.4.219]) by smtp.gmail.com with ESMTPSA id t17sm1690165qto.92.2021.05.20.05.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 05:46:38 -0700 (PDT) Date: Thu, 20 May 2021 08:46:36 -0400 From: Peter Xu To: "Aneesh Kumar K.V" Cc: Nathan Chancellor , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy Subject: Re: [PATCH v5 3/9] mm/mremap: Use pmd/pud_poplulate to update page table entries Message-ID: References: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> <20210422054323.150993-4-aneesh.kumar@linux.ibm.com> <87mtsrqqk0.fsf@linux.ibm.com> <6e0dbb76-2b33-53f1-246e-30cec2b871e2@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <6e0dbb76-2b33-53f1-246e-30cec2b871e2@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4QuOoug; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 02C27A0001CD X-Stat-Signature: emhab9fuempcccpkbhmrs3pmeysd1ccs X-HE-Tag: 1621514799-909927 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 20, 2021 at 01:56:54PM +0530, Aneesh Kumar K.V wrote: > > This seems to work at least for my userfaultfd test on shmem, however I don't > > fully understand the commit message [1] on: How do we guarantee we're not > > moving a thp pte? > > > > move_page_tables() checks for pmd_trans_huge() and ends up calling > move_huge_pmd if it is a THP entry. Sorry to be unclear: what if a huge pud thp? -- Peter Xu