From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60206C433B4 for ; Wed, 19 May 2021 14:49:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C354C6105A for ; Wed, 19 May 2021 14:49:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C354C6105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 222936B0036; Wed, 19 May 2021 10:49:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D3586B006E; Wed, 19 May 2021 10:49:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 025156B0070; Wed, 19 May 2021 10:49:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id C42E06B0036 for ; Wed, 19 May 2021 10:49:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AB980B7A9 for ; Wed, 19 May 2021 14:49:37 +0000 (UTC) X-FDA: 78158264394.27.D626186 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf16.hostedemail.com (Postfix) with ESMTP id 961438019107 for ; Wed, 19 May 2021 14:49:36 +0000 (UTC) Received: by mail-qv1-f48.google.com with SMTP id h7so6245955qvs.12 for ; Wed, 19 May 2021 07:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b1cKAWledUKzuSk9jerfXLCilJo3n8tNR9Bz+0Q0Vh4=; b=te0/qxL9TcrFvl1dO4HGMr+lXCD26GOdpn+KYDCZbm8ciHnla/km/LauSremC2iJvb Q0LcXNJyQp01XRb+HKV73QLLC75DiZPJwr+WGnlwAfV8+/sQVQLc71Oa0xOLg6NgB3w5 zDPzBf2eu3hzSuyyNB4B+vAxQpoy102mdklXqhkU21Zw12cm0KFeZY9gT20JEgZ28lep s4qReOOk35qhBKaENcGMQGApnLlGDLBI9PAKpqePbXEm+BDqFufLJaMJnDj48xoZuGiZ +w/kXclpVAmCEKz8dJf0V0WA86kJAttGVbNRv1G6mqWkbzbslnFdZRzWMekbTZtJ0dzc s4eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b1cKAWledUKzuSk9jerfXLCilJo3n8tNR9Bz+0Q0Vh4=; b=siD2R5rQiJ8ntEFNQ5JyropWTnTHqcoUpGC0CN2JGUxeHIs2OpthpQk8u0FRekQLmZ t9WZc4gG3PP17rknyH5axHGxtcJ+Ui/89R+YBJgj7r6yqWHyA+IlQ1vXC48CJCWtrTnb qAKq5o24kAypAEEJB2ZK3xSVQB/X+516fZ6uLYTpOkx2Qz8EhS6nkpf5nS9YMd4ipgne BaOVGn6kfyVPMJlhY1rx2f7IDbc7MFvT5UYw3b4VA2Oz7WmhrZdR4komWRAmCDJOdkOA 2ZrjoUmRTIJYxrjs1lvS8rribWK61xxiSaY+S1mCg9HuzUUzd9n63GC1lj8x7x6H4K5Y Vz7A== X-Gm-Message-State: AOAM53385/RFAH2lA9w5khCf9pQMHgJNI/4tvMSon1yipJvCiPwbcKRo Pp+ojkHVsFEG7YfW8jLd9OT0KA== X-Google-Smtp-Source: ABdhPJzCjYfPDXZjtVIoZuZSY3z3AIvZYlCHTyKWoFxc6mHjeHmiZ4aFQCmZCupvM/XdurrKzdjmgg== X-Received: by 2002:a0c:aa1d:: with SMTP id d29mr8663690qvb.47.1621435776189; Wed, 19 May 2021 07:49:36 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:a4dd]) by smtp.gmail.com with ESMTPSA id j6sm15214930qti.4.2021.05.19.07.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 07:49:35 -0700 (PDT) Date: Wed, 19 May 2021 10:49:33 -0400 From: Johannes Weiner To: Huang Ying Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Linus Torvalds , Peter Xu , Hugh Dickins , Mel Gorman , Rik van Riel , Andrea Arcangeli , Michal Hocko , Dave Hansen , Tim Chen Subject: Re: [PATCH] mm: move idle swap cache pages to the tail of LRU after COW Message-ID: References: <20210519013313.1274454-1-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210519013313.1274454-1-ying.huang@intel.com> X-Rspamd-Queue-Id: 961438019107 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b="te0/qxL9"; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam04 X-Stat-Signature: qsydr8sx36n43m9ngo8wcerk55j9pt3h X-HE-Tag: 1621435776-764258 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 19, 2021 at 09:33:13AM +0800, Huang Ying wrote: > diff --git a/mm/memory.c b/mm/memory.c > index b83f734c4e1d..2b6847f4c03e 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3012,6 +3012,11 @@ static vm_fault_t wp_page_copy(struct vm_fault *vmf) > munlock_vma_page(old_page); > unlock_page(old_page); > } > + if (page_copied && PageSwapCache(old_page) && > + !page_mapped(old_page) && trylock_page(old_page)) { > + try_to_free_idle_swapcache(old_page); > + unlock_page(old_page); If there are no more swap or pte references, can we just attempt to free the page right away, like we do during regular unmap? if (page_copied) free_swap_cache(old_page); put_page(old_page);