From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1BFC433ED for ; Tue, 18 May 2021 21:35:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD3CC61244 for ; Tue, 18 May 2021 21:35:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD3CC61244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B6FC6B010A; Tue, 18 May 2021 17:35:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3539C6B010B; Tue, 18 May 2021 17:35:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F5396B010C; Tue, 18 May 2021 17:35:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id E17976B010A for ; Tue, 18 May 2021 17:35:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 848DF62C4 for ; Tue, 18 May 2021 21:35:18 +0000 (UTC) X-FDA: 78155657916.16.4F60A12 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id C2E34C000C57 for ; Tue, 18 May 2021 21:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Mgp8VIxRG3WR01A5wXzYm9aqAFHvu+NrxQhHQf3pQXA=; b=FCpC8gTKwh4qTrv8AtyZqv8Pfj 69zVY3VeTFVQejhk+DWiDINdL3N3cvvZny8Nx0Kli0gfaKsExw9bvRxgpwPr/Ckf0eeESh/0sibRl ilO6VMrFuDIay7vBTYNbyNwe+QXh4CBFNmr044dbZTXeZ9uB73JzudZPJ8vJgXJdN5DHhRgJsiBpR fqKZDIMagu3IpYMFCcLvSQzkZFS0l01o2n1KZzpK7bbqvCyX7L51mepkVLVmKNq1hW9htDgCFGDLD 6hqrr+m/gYd3u135eT5IpTXP2E8wXV6xST6AZSOTmaMY0pUGMAqMxn5/0x0bwVhkcQSXWqK9FqbCo gszftbKw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lj7MX-00EMrX-Bd; Tue, 18 May 2021 21:34:51 +0000 Date: Tue, 18 May 2021 22:34:49 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Miaohe Lin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page() Message-ID: References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-6-linmiaohe@huawei.com> <20210518141304.c09cd8762e3f3d16a722444c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518141304.c09cd8762e3f3d16a722444c@linux-foundation.org> Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FCpC8gTK; dmarc=none; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C2E34C000C57 X-Stat-Signature: j3ht64poeconmptx4k3k8ehc7p8d7h53 X-HE-Tag: 1621373717-485920 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 02:13:04PM -0700, Andrew Morton wrote: > On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox wrote: > > > On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote: > > > pagecache_get_page() can do find_subpage() for us if we do not specify > > > FGP_HEAD. No functional change intended. > > > > Please, no. This interferes with the folio work. > > In what way? Can't the folio patches simply revert this or suitably > alter it? Of course, it's just software. Anything can just be modified. I don't see the point of putting in a cleanup patch that creates a conflict with important work.