From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA1FC433ED for ; Tue, 18 May 2021 14:35:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A139C610CC for ; Tue, 18 May 2021 14:35:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A139C610CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F3E4F8E0039; Tue, 18 May 2021 10:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC7B88E002F; Tue, 18 May 2021 10:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D40F28E0039; Tue, 18 May 2021 10:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id 98ABD8E002F for ; Tue, 18 May 2021 10:35:31 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 18935A8EF for ; Tue, 18 May 2021 14:35:31 +0000 (UTC) X-FDA: 78154600062.14.8A90293 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id C5ABEE000105 for ; Tue, 18 May 2021 14:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V41BGrwJAcDzACJWMGS38sqXTQTEeXnRt0JcY9r2fHM=; b=nDtysvCwvj0uv29VbSGeK/Qtw3 1QYK2aKJNx7PGsK48QQxqSQPjPAij9Gv7wQ7kkATWLHVyWMRlru7ZlDE6y8grK24lSNQdPS8D+VFe XfXnxGtJld78JsTPiM5A07ecX5GE83v78LUpVNHUCR8RQazwpMMYU0GSa/ilJIRuWQZ2jtxVoK7dQ 4lTCkahRXTrTmRqLWxYzk6gxKgPJKjHPtFQnhPfoynv6axP8hwnPMt60dlk07m+kS+w5XosVpJVuY S9q58kwkDzF/rgwB25Hbiit3gJovNOwOtDWnvAejCJTrpHCczGr3QgndRxp1PqsPHb4zqXjDykF5c UV3cGH3w==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lj0nC-00E3nb-O5; Tue, 18 May 2021 14:34:01 +0000 Date: Tue, 18 May 2021 15:33:54 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page() Message-ID: References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-6-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210518135352.3705306-6-linmiaohe@huawei.com> X-Rspamd-Queue-Id: C5ABEE000105 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nDtysvCw; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 6uzijb69rxhyxtrty77ebdf6dhotmfnt X-HE-Tag: 1621348526-148986 X-Bogosity: Ham, tests=bogofilter, spamicity=0.015575, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote: > pagecache_get_page() can do find_subpage() for us if we do not specify > FGP_HEAD. No functional change intended. Please, no. This interferes with the folio work.