From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535E6C43461 for ; Tue, 18 May 2021 13:29:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBA1B6100C for ; Tue, 18 May 2021 13:29:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBA1B6100C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FD758E0027; Tue, 18 May 2021 09:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D5618E0023; Tue, 18 May 2021 09:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501868E0027; Tue, 18 May 2021 09:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 1ED8F8E0023 for ; Tue, 18 May 2021 09:29:01 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BD6A2180AD830 for ; Tue, 18 May 2021 13:29:00 +0000 (UTC) X-FDA: 78154432440.37.F22740A Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by imf22.hostedemail.com (Postfix) with ESMTP id 4A742C0007E3 for ; Tue, 18 May 2021 13:28:59 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 112361363; Tue, 18 May 2021 09:28:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 18 May 2021 09:28:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ga/TZj/5vAgtR0dCH9rcrEvjoBQ +Qmj6N01DxKSJ5Hg=; b=j4U/88rHJ4axiebD9NMyOxDn7M+yhUnvt/EmDkwSyBa esQ4fFKuE08eF7T+C34PKg3xxwe5uSklju7N5xhg1hmTpYYQKwgtvLPnWnFIALfL shW44ftnfabTj9n6b/fI40tc8pRWzJEHD8s5YuZ36RuUGRIsheFKE+uO45lXKTul /PE1dqbnb6mRbLsaYKsPdosXL4CbuadpovqMhFefdzmxJsA1l3dxZxFG9vVUtQU6 95A8cyvQ8KAXO3uZwSOdEb8on1m1IoDLBc0Oa8KJpB1Qdfz6dNd9DHGSHGm/Rby7 MBhsN/DHx+hwI+z59SNHzN1BtgFNHiHlKVGxcSYRXRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ga/TZj /5vAgtR0dCH9rcrEvjoBQ+Qmj6N01DxKSJ5Hg=; b=jvNPXILWdiAiOeWhZ+ZG+E gKUTpQteePibi7OTTwubqTzpzJ69i7xoHwDXvwwxsbCHYEqDrC5WX0zvmp2FyO1+ gkOdAawhDCb4Ukqln1c7us1YoHpLGws00fUFoEpFhdRgb28lXbfp5BVzUsDDnwCh 28t6mvwLdpEEo6gvqrYGyIRF5sZjYofOsvsJPpZy/tAdFsZonGrFw6ls2WdkxasC dPtxInNry9fHE2RWnpQ9X0pExERdBh7K0pL8x49Z6Nf38OTkZJBYOIY7mfuNKzIu +GPOp2/Nr23cNBASQ1pOOCTMUBabxfXShV1RU9B4sF1T4d5EB5vmT7xlQIu2XIVQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeijedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucfkphepkeef rdekiedrjeegrdeigeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 May 2021 09:28:56 -0400 (EDT) Date: Tue, 18 May 2021 15:28:54 +0200 From: Greg KH To: Faiyaz Mohammed Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, glittao@gmail.com, vinmenon@codeaurora.org Subject: Re: [PATCH v6] mm: slub: move sysfs slab alloc/free interfaces to debugfs Message-ID: References: <1621341949-26762-1-git-send-email-faiyazm@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621341949-26762-1-git-send-email-faiyazm@codeaurora.org> Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm3 header.b="j4U/88rH"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=jvNPXILW; dmarc=none; spf=pass (imf22.hostedemail.com: domain of greg@kroah.com designates 64.147.123.27 as permitted sender) smtp.mailfrom=greg@kroah.com X-Stat-Signature: s5m68e6579i1p9ocqkj199wshngdojrr X-Rspamd-Queue-Id: 4A742C0007E3 X-Rspamd-Server: rspam02 X-HE-Tag: 1621344539-626266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 06:15:49PM +0530, Faiyaz Mohammed wrote: > alloc_calls and free_calls implementation in sysfs have two issues, > one is PAGE_SIZE limitiation of sysfs and other is it does not adhere > to "one value per file" rule. > > To overcome this issues, move the alloc_calls and free_calls implemeation > to debugfs. > > Rename the alloc_calls/free_calls to alloc_traces/free_traces, > to be inline with what it does. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Faiyaz Mohammed > --- > include/linux/slub_def.h | 8 ++ > mm/slab_common.c | 9 ++ > mm/slub.c | 359 ++++++++++++++++++++++++++++++++++++----------- > 3 files changed, 294 insertions(+), 82 deletions(-) If this is v6, what happened in v1-5? That should always be below the --- line, right?