From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C030C47082 for ; Wed, 26 May 2021 19:41:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 98C2D613D3 for ; Wed, 26 May 2021 19:41:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98C2D613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1BBD96B0036; Wed, 26 May 2021 15:41:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16C976B006E; Wed, 26 May 2021 15:41:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDA3E6B0070; Wed, 26 May 2021 15:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id BB8956B0036 for ; Wed, 26 May 2021 15:41:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5113F6125 for ; Wed, 26 May 2021 19:41:12 +0000 (UTC) X-FDA: 78184400784.25.77E36A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 9BED0600025E for ; Wed, 26 May 2021 19:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622058071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IK6Th4ZCx+0amLJEZjMrTW9bDpGzITHnRAL9h8VgscA=; b=ZV5MmiOxp6cFaupevgIBPi+3x03Bkd24qjoGhlH389dIjzps2WGegOLjnYuWXyi1xsCDlz 3WfY7/xAIPZl7HBh5BkmYxdBeK+j+FtTRtwm6y5sJjSNvnaFfuOEpKWm44oaoTfgGlKQaX Of/yYe8irIJfXooknise8QwntP3z1aE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-MjDFDH5sPeCjtZU2WrGXxA-1; Wed, 26 May 2021 15:41:09 -0400 X-MC-Unique: MjDFDH5sPeCjtZU2WrGXxA-1 Received: by mail-qv1-f72.google.com with SMTP id d3-20020a0cdb030000b029021313001eeeso1911416qvk.15 for ; Wed, 26 May 2021 12:41:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IK6Th4ZCx+0amLJEZjMrTW9bDpGzITHnRAL9h8VgscA=; b=FA/SOu0++PbCCFNqrznq1clg5rj5ml0yM2VYtvPdijmJvGEg0azNpHsS+r4gNagzib abLueP8FrsXoZZsKhxd3DGzWnmuK0PhMCxy/KTIPRD9qGeBUHC//vgY4LZBGVLXUnJlW ubg5ljK44XCulhjNjTeCv3BocAAW0r+zDvSn7LFw5RTLB1hmvYYs+RXz75Qf0zzjJP2Q Ya3y8qsOkdbeWFAGrNKHhO8QAe/SsUfhK7MPuBfAXwaPaAMKWxoG7Kdsi6d0wgiMKHLk 1xZ50A1ku4WrMYAClWDazw2DmaNiDaOdHYJSB1NmgcRAFKITZfb5vG515zsSoGetLU4S O+Hg== X-Gm-Message-State: AOAM531dJ/dn31sgVgxlBGBR3MAZm5Q6Ri4eO19+ypUpYgpAC6Y6Ivfw 6AZu/9RKEwsXmVotudEWzJCj2l9b/pzI04xVVaITIRtFg0KGLF6Kg7qVq3KCmnScBEv+Ow33DX3 zLLLafpu2HGQ= X-Received: by 2002:ac8:5bc2:: with SMTP id b2mr38732469qtb.220.1622058069381; Wed, 26 May 2021 12:41:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJnPqtQWXkJ/e/uDJethFbtPOcM3K9BKum6Ztqo6rrKUmjkHKDiiSLmcCX23fB6dWiie8WzA== X-Received: by 2002:ac8:5bc2:: with SMTP id b2mr38732446qtb.220.1622058069146; Wed, 26 May 2021 12:41:09 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-72-184-145-4-219.dsl.bell.ca. [184.145.4.219]) by smtp.gmail.com with ESMTPSA id j1sm2056219qtn.83.2021.05.26.12.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 12:41:08 -0700 (PDT) Date: Wed, 26 May 2021 15:41:07 -0400 From: Peter Xu To: Alistair Popple Cc: linux-mm@kvack.org, akpm@linux-foundation.org, nouveau@lists.freedesktop.org, bskeggs@redhat.com, rcampbell@nvidia.com, linux-doc@vger.kernel.org, jhubbard@nvidia.com, bsingharora@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, hch@infradead.org, jglisse@redhat.com, willy@infradead.org, jgg@nvidia.com, hughd@google.com Subject: Re: [PATCH v9 05/10] mm: Rename migrate_pgmap_owner Message-ID: References: <20210524132725.12697-1-apopple@nvidia.com> <20210524132725.12697-6-apopple@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20210524132725.12697-6-apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZV5MmiOx; spf=none (imf09.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9BED0600025E X-Stat-Signature: gm6d6sgdoox79smobowj1bg6i318ztqp X-HE-Tag: 1622058067-157931 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 24, 2021 at 11:27:20PM +1000, Alistair Popple wrote: > @@ -521,14 +521,14 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, > range->flags = flags; > } > > -static inline void mmu_notifier_range_init_migrate( > - struct mmu_notifier_range *range, unsigned int flags, > +static inline void mmu_notifier_range_init_owner( > + struct mmu_notifier_range *range, > + enum mmu_notifier_event event, unsigned int flags, > struct vm_area_struct *vma, struct mm_struct *mm, > - unsigned long start, unsigned long end, void *pgmap) > + unsigned long start, unsigned long end, void *owner) > { > - mmu_notifier_range_init(range, MMU_NOTIFY_MIGRATE, flags, vma, mm, > - start, end); > - range->migrate_pgmap_owner = pgmap; > + mmu_notifier_range_init(range, event, flags, vma, mm, start, end); > + range->owner = owner; > } mmu_notifier_range_init_migrate() can even be kept to just call the new helper, then existing callers are unaffected. Not a big deal, though: Reviewed-by: Peter Xu Thanks, -- Peter Xu