From: Roman Gushchin <guro@fb.com>
To: Hillf Danton <hdanton@sina.com>
Cc: Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, Alexander Viro <viro@zeniv.linux.org.uk>,
Dennis Zhou <dennis@kernel.org>,
Dave Chinner <dchinner@redhat.com>, <cgroups@vger.kernel.org>
Subject: Re: [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by switching attached inodes
Date: Thu, 27 May 2021 09:29:56 -0700 [thread overview]
Message-ID: <YK/JBDxsZQwC0q8J@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20210527032459.2306-1-hdanton@sina.com>
On Thu, May 27, 2021 at 11:24:59AM +0800, Hillf Danton wrote:
> On Wed, 26 May 2021 15:25:57 -0700 Roman Gushchin wrote:
> >+
> >+ if (!list_empty(&offline_cgwbs))
> >+ schedule_work(&cleanup_offline_cgwbs_work);
> >+
>
> Good work overall.
Thanks!
>
> Nit, given cond_resched_lock() in cleanup_offline_wb(), what you need instead
> is
> queue_work(system_unbound_wq, &cleanup_offline_cgwbs_work);
Neat, will do in the next version.
Thanks!
next prev parent reply other threads:[~2021-05-27 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 22:25 [PATCH v5 0/2] cgroup, blkcg: prevent dirty inodes to pin dying memory cgroups Roman Gushchin
2021-05-26 22:25 ` [PATCH v5 1/2] writeback, cgroup: keep list of inodes attached to bdi_writeback Roman Gushchin
2021-05-27 10:35 ` Jan Kara
2021-05-27 16:32 ` Roman Gushchin
2021-05-26 22:25 ` [PATCH v5 2/2] writeback, cgroup: release dying cgwbs by switching attached inodes Roman Gushchin
2021-05-27 3:24 ` Hillf Danton
2021-05-27 16:29 ` Roman Gushchin [this message]
2021-05-27 11:24 ` Jan Kara
2021-05-27 17:48 ` Roman Gushchin
2021-05-27 19:45 ` Roman Gushchin
2021-05-28 13:05 ` Jan Kara
2021-05-28 16:25 ` Roman Gushchin
2021-05-28 2:58 ` Ming Lei
2021-05-28 16:22 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK/JBDxsZQwC0q8J@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=cgroups@vger.kernel.org \
--cc=dchinner@redhat.com \
--cc=dennis@kernel.org \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox