From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 869D8C433ED for ; Wed, 12 May 2021 12:06:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E564861413 for ; Wed, 12 May 2021 12:06:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E564861413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 308F16B0036; Wed, 12 May 2021 08:06:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E0386B006E; Wed, 12 May 2021 08:06:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D0C26B0070; Wed, 12 May 2021 08:06:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 023C36B0036 for ; Wed, 12 May 2021 08:06:19 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0390181AF5FA for ; Wed, 12 May 2021 12:06:19 +0000 (UTC) X-FDA: 78132451278.38.266536F Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id DFDBA40B8CC6 for ; Wed, 12 May 2021 12:06:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3CB7561403; Wed, 12 May 2021 12:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620821177; bh=AtszGnmv+mTFcNm2ERPbG7WIHAhG6jxQCBij84CLFdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r6w4bQUu9wMMwJP+sZjszQ5ZOhmY9vBlAzAybojQ7W49bbpVpctrfAWfPvSeGBGtB s98qHhnDFqsGlJWC78tHp7JJX35rbkKhsYjaNVnONQXmNia2/jzoBZN1kCuSY2dqf3 u1fhj3H+DdHYfFX9NRIcgPCmGYDDb4s6tc7r5+/0= Date: Wed, 12 May 2021 14:06:15 +0200 From: Greg KH To: Kefeng Wang Cc: Jing Xiangfeng , Nicolas Saenz Julienne , catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, rppt@kernel.org, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, song.bao.hua@hisilicon.com, ardb@kernel.org, anshuman.khandual@arm.com, bhelgaas@google.com, guro@fb.com, robh+dt@kernel.org, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, frowand.list@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA Message-ID: References: <20210303073319.2215839-1-jingxiangfeng@huawei.com> <9bc396116372de5b538d71d8f9ae9c3259f1002e.camel@suse.de> <827b317d7f5da6e048806922098291faacdb19f9.camel@suse.de> <604597E3.5000605@huawei.com> <31cd8432-2466-555d-7617-ae48cbcd4244@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31cd8432-2466-555d-7617-ae48cbcd4244@huawei.com> Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=r6w4bQUu; spf=pass (imf26.hostedemail.com: domain of gregkh@linuxfoundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DFDBA40B8CC6 X-Stat-Signature: zsdbo9fucyue9pinsgp453pwnx99toid Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620821164-451620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 11, 2021 at 08:35:47PM +0800, Kefeng Wang wrote: > > > On 2021/3/8 17:58, Greg KH wrote: > > On Mon, Mar 08, 2021 at 11:20:03AM +0800, Jing Xiangfeng wrote: > > > > > > > > > On 2021/3/7 23:24, Greg KH wrote: > > > > On Thu, Mar 04, 2021 at 04:09:28PM +0100, Nicolas Saenz Julienne wrote: > > > > > On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote: > > > > > > On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne wrote: > > > > > > > Hi Greg. > > > > > > > > > > > > > > On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote: > > > > > > > > On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote: > > > > > > > > > Using two distinct DMA zones turned out to be problematic. Here's an > > > > > > > > > attempt go back to a saner default. > > > > > > > > What problem does this solve? How does this fit into the stable kernel > > > > > > > > rules? > > > > > > > We changed the way we setup memory zones in arm64 in order to cater for > > > > > > > Raspberry Pi 4's weird DMA constraints: ZONE_DMA spans the lower 1GB of memory > > > > > > > and ZONE_DMA32 the rest of the 32bit address space. Since you can't allocate > > > > > > > memory that crosses zone boundaries, this broke crashkernel allocations on big > > > > > > > machines. This series fixes all this by parsing the HW description and checking > > > > > > > for DMA constrained buses. When not found, the unnecessary zone creation is > > > > > > > skipped. > > > > > > What kernel/commit caused this "breakage"? > > > > > 1a8e1cef7603 arm64: use both ZONE_DMA and ZONE_DMA32 > > > > Thanks for the info, all now queued up. > > > There is a fix in 5.11. Please consider applying the following commit to > > > 5.10.y: > > > > > > aed5041ef9a3 of: unittest: Fix build on architectures without > > > CONFIG_OF_ADDRES > > > > Thanks, now queued up. > > Hi Grep, another commit d78050ee3544 "arm64: Remove arm64_dma32_phys_limit > and its uses" should be involved, thanks. > > "Prior to this patch, disabling CONFIG_ZONE_DMA32 leads to CMA > allocation from the whole RAM as arm64_dma32_phys_limit becomes > PHYS_MASK+1." from Catalin, see more from the link > https://www.spinics.net/lists/arm-kernel/msg867356.html Ok, now queued up. greg k-h