From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D2CC433ED for ; Wed, 12 May 2021 03:39:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26F83613EE for ; Wed, 12 May 2021 03:39:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26F83613EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 544726B0036; Tue, 11 May 2021 23:39:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51BE86B006E; Tue, 11 May 2021 23:39:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E3866B0070; Tue, 11 May 2021 23:39:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 25B516B0036 for ; Tue, 11 May 2021 23:39:23 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CEB268249980 for ; Wed, 12 May 2021 03:39:22 +0000 (UTC) X-FDA: 78131173764.38.D7E7C09 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id DF5D3132 for ; Wed, 12 May 2021 03:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Z81zFfDbHvSBXYaN37BiINzs0xNphc/huvF7lVWQMLg=; b=Y+7qa1HD1P+Ab3uJT25iunfmtX uXSVnfnwxvWZo51hWgtJ4McOXGilbkXjGEMdIiQeIQPeHhu6n7+JOBG29ucCohRFzCv4ipG2PTYW+ oEcHhEQFfzWp1njZ24cy7BZ1kGjoRIIP43dyxA9Q7SAQVrCO9nWg6PiJGVxxP+xRDsAeyp7YYhHOz OWH3OrMxxcJhgz8XY63Bh9jDrcuDEdlnRCoq1UV7cmeknz2bSKfd2OVcixEf8Sm68E264A8nOv3qE cPDW6jvyCDa0Zsowx6FwA/9I2qXUBJLb89d4FbJHTBHhEOHiwKZytxmiSHNp6CBjUUHDXr9Q1hpxF wfS3NfjA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgfhs-007uLE-TT; Wed, 12 May 2021 03:38:56 +0000 Date: Wed, 12 May 2021 04:38:44 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, William Kucharski , Vlastimil Babka , Anshuman Khandual Subject: Re: [PATCH 3/8] mm/debug: Factor PagePoisoned out of __dump_page Message-ID: References: <20210430145549.2662354-1-willy@infradead.org> <20210430145549.2662354-4-willy@infradead.org> <2baf684e-f35d-5c42-fa11-1e061a12a81f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2baf684e-f35d-5c42-fa11-1e061a12a81f@huawei.com> X-Rspamd-Queue-Id: DF5D3132 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Y+7qa1HD; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: z4rjqpkoiqho61ji4dbrhn38fwgctd14 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620790755-411728 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 12, 2021 at 11:29:06AM +0800, Kefeng Wang wrote: > > void dump_page(struct page *page, const char *reason) > > { > > - __dump_page(page, reason); > > + if (PagePoisoned(page)) > > + pr_warn("page:%p is uninitialized and poisoned", page); > > + else > > + __dump_page(page); > > Hi Matthew, dump_page_owenr() should be called when !PagePoisoned, right? > > > > + if (reason) > > + pr_warn("page dumped because: %s\n", reason); > > dump_page_owner(page); > > } > > EXPORT_SYMBOL(dump_page); dump_page_owner() is called whether the page is Poisoned or not ... both before and after this patch. Is there a problem with that?