From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87F6C433B4 for ; Wed, 12 May 2021 03:14:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D0DF61943 for ; Wed, 12 May 2021 03:14:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D0DF61943 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A90EE6B0036; Tue, 11 May 2021 23:14:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A403D6B006E; Tue, 11 May 2021 23:14:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F616B0070; Tue, 11 May 2021 23:14:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 769C66B0036 for ; Tue, 11 May 2021 23:14:46 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3E2BC6126 for ; Wed, 12 May 2021 03:14:46 +0000 (UTC) X-FDA: 78131111772.23.B64249C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id BAA80C0007F4 for ; Wed, 12 May 2021 03:14:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ikQ41RlJwrGMcA091zj9/uV4xrqM2kq1Y5GRuRy1/n4=; b=Z/blpsXJZSz93O3+ZclMM7GD+m i5SWNkKM3phfo9jPdppT/b2MgSSKrI//Q8iUqs6zwHUifxCzhl0qszp2wWntQVsWLYd9qLcBhVGw6 4KtkG4ZrlF+QC2TxAv1BsjAf93n9zWbQzXugCSj5dBvwUE7lh7wJPbBbY19nMzj9J6DrcX4WKEDSg 5ken6jREJqN5Lz81EWAOr46wwuaGGPPbwmUI3qaKycnfAtwEg//sxXCyy4+KSzXW8JsBmlHyFhOgD 3BLBq9jjErdc4a5aVgZHyDOnrgEqjfaIiPZgK2UqtxKQqn6hPtlh3UAUHOBbwrCu5U8qoK977Otp0 VqjBhjFg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgfKH-007tYD-8D; Wed, 12 May 2021 03:14:25 +0000 Date: Wed, 12 May 2021 04:14:21 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/page_alloc: Use dump_page() directly Message-ID: References: <20210512031057.13580-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210512031057.13580-1-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: BAA80C0007F4 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="Z/blpsXJ"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 3pdnkrwfhhh117koryewnp3buzq5ot56 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620789285-817368 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 12, 2021 at 11:10:55AM +0800, Kefeng Wang wrote: > Simplfy use dump_page(). https://lore.kernel.org/linux-mm/20210430145549.2662354-3-willy@infradead.org/ > Signed-off-by: Kefeng Wang > --- > mm/page_alloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index a2fe714aed93..f23702e7c564 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -658,8 +658,7 @@ static void bad_page(struct page *page, const char *reason) > > pr_alert("BUG: Bad page state in process %s pfn:%05lx\n", > current->comm, page_to_pfn(page)); > - __dump_page(page, reason); > - dump_page_owner(page); > + dump_page(page, reason); > > print_modules(); > dump_stack(); > -- > 2.26.2 >