From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/page_alloc: Use dump_page() directly
Date: Wed, 12 May 2021 04:14:21 +0100 [thread overview]
Message-ID: <YJtIDeb+Y2eNu0bs@casper.infradead.org> (raw)
In-Reply-To: <20210512031057.13580-1-wangkefeng.wang@huawei.com>
On Wed, May 12, 2021 at 11:10:55AM +0800, Kefeng Wang wrote:
> Simplfy use dump_page().
https://lore.kernel.org/linux-mm/20210430145549.2662354-3-willy@infradead.org/
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> mm/page_alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index a2fe714aed93..f23702e7c564 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -658,8 +658,7 @@ static void bad_page(struct page *page, const char *reason)
>
> pr_alert("BUG: Bad page state in process %s pfn:%05lx\n",
> current->comm, page_to_pfn(page));
> - __dump_page(page, reason);
> - dump_page_owner(page);
> + dump_page(page, reason);
>
> print_modules();
> dump_stack();
> --
> 2.26.2
>
prev parent reply other threads:[~2021-05-12 3:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 3:10 Kefeng Wang
2021-05-12 3:10 ` [PATCH 2/3] mm: Make __dump_page() static Kefeng Wang
2021-05-12 3:10 ` [PATCH 3/3] mm/debug: Check page poisoned firstly in dump_page() Kefeng Wang
2021-05-12 3:15 ` Matthew Wilcox
2021-05-12 3:23 ` Kefeng Wang
2021-05-12 3:14 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJtIDeb+Y2eNu0bs@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox