From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1BA3C433ED for ; Tue, 11 May 2021 23:05:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CCB461606 for ; Tue, 11 May 2021 23:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CCB461606 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 47B8E6B0036; Tue, 11 May 2021 19:05:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C486B006C; Tue, 11 May 2021 19:05:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CCA06B006E; Tue, 11 May 2021 19:05:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 132816B0036 for ; Tue, 11 May 2021 19:05:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C2D4B181AF5D0 for ; Tue, 11 May 2021 23:05:50 +0000 (UTC) X-FDA: 78130484460.02.DD5322E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C0D972000261 for ; Tue, 11 May 2021 23:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p90x9jEmQHND6fT7ufpXCKutOlzP8zjwAk/wUNBLalg=; b=U8SozuRvdhbYdNEKn+H/SqM6pR j31ruaTHW/AhJl8hSkM10yLKM/b8XqCa+aX4G4eg/6/vQgo69mxwNtIgiRtJD6tKQIqE51zXxGi8Z tku0eiD1yfoSJ3xNwIHV7++0vuQCFPCwgUCChBv0MiuvqKHF7Mr0q/vvyNKHGqIn353bMZRdKn1j4 be2BJYeT+JMlhnupBDlT2ANFfIVAm/8F5SPL56ujiiIjfI/d7/6QFhF513bG3Sker7cv3uyaJw3Zq VjDRbgxhEa+9DiIqXBs7XFLrhLuXtM5l6LDr1m0SjRMj5CepfvilFtDf9b474sw7eYytMm1aoCqxz 4sQhcsvQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgbPa-007l6k-Jc; Tue, 11 May 2021 23:03:42 +0000 Date: Wed, 12 May 2021 00:03:34 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, ziy@nvidia.com, william.kucharski@oracle.com, yang.shi@linux.alibaba.com, aneesh.kumar@linux.ibm.com, rcampbell@nvidia.com, songliubraving@fb.com, kirill.shutemov@linux.intel.com, riel@surriel.com, hannes@cmpxchg.org, minchan@kernel.org, hughd@google.com, adobriyan@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 2/5] mm/huge_memory.c: use page->deferred_list Message-ID: References: <20210511134857.1581273-1-linmiaohe@huawei.com> <20210511134857.1581273-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511134857.1581273-3-linmiaohe@huawei.com> X-Rspamd-Queue-Id: C0D972000261 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=U8SozuRv; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam03 X-Stat-Signature: ye5nhj9ajct8zgjkz4fqa8nrexad4gia Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620774348-793191 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 11, 2021 at 09:48:54PM +0800, Miaohe Lin wrote: > Now that we can represent the location of ->deferred_list instead of > ->mapping + ->index, make use of it to improve readability. > > Reviewed-by: Yang Shi > Reviewed-by: David Hildenbrand > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 63ed6b25deaa..76ca1eb2a223 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2868,7 +2868,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > /* Take pin on all head pages to avoid freeing them under us */ > list_for_each_safe(pos, next, &ds_queue->split_queue) { > - page = list_entry((void *)pos, struct page, mapping); > + page = list_entry((void *)pos, struct page, deferred_list); > page = compound_head(page); This is an equivalent transformation, but it doesn't really go far enough. I think you want something like this: struct page *page, *next; list_for_each_entry_safe(page, next, &ds_queue->split_queue, deferred_list) { struct page *head = page - 1; ... then use head throughout ... }