From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DC6C433ED for ; Mon, 10 May 2021 19:57:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B8986143C for ; Mon, 10 May 2021 19:57:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8986143C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A92276B0070; Mon, 10 May 2021 15:57:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A43B46B0071; Mon, 10 May 2021 15:57:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E3CB6B0072; Mon, 10 May 2021 15:57:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 6F9316B0070 for ; Mon, 10 May 2021 15:57:26 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 237F26D74 for ; Mon, 10 May 2021 19:57:26 +0000 (UTC) X-FDA: 78126380892.35.62D7974 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 6FE80801938A for ; Mon, 10 May 2021 19:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Kb38thZlbl33NciqGP4Ww1F/3vhXvHqKbnItEFr8wc=; b=XfONCcyx7NKtkbmdJHx54H0AvU GdvfPFweatTjTbhL2RbxGz15j87DKjGy3BmPobPwOcZNR0/TV5MrKlI8RGNVUCT8EnpSGyS17mY1Z MIiXBxYDMWGrUuCyONvBgOVKMZoTWDOpy7TgXXVuebLQ0EwXBLmk0fKK2AOLLHZJV7Yi74WHMoWHM 3vwoXH2YLZQQMvkxCTvO/vdXXEt85Hj4JJp59V/hlaPyri7fDtjTXTKnLBMWCILxAvVBRB1hsfG0q P+RAqHsQhm397mc3JyTwlqE6jGaslwy+cOnCrQS0eXqZK+eH1F2HxHsYRh1d81VCVoWwmXI/wYBsd JcGtNrrw==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgC1O-006WlH-V3; Mon, 10 May 2021 19:57:00 +0000 Date: Mon, 10 May 2021 20:56:54 +0100 From: Matthew Wilcox To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Michel Lespinasse Subject: Re: [PATCH] mm/mmap: Introduce unlock_range() for code cleanup Message-ID: References: <20210510195020.2778501-1-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510195020.2778501-1-Liam.Howlett@Oracle.com> Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XfONCcyx; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6FE80801938A X-Stat-Signature: a3ikz1fzt45s66fqq1w9q34bjynochnb Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620676644-424663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 10, 2021 at 07:50:22PM +0000, Liam Howlett wrote: > Both __do_munmap() and exit_mmap() unlock a range of VMAs using almost > identical code blocks. Replace both blocks by a static inline function. > > Signed-off-by: Liam R. Howlett Reviewed-by: Matthew Wilcox (Oracle) > +static inline void unlock_range(struct vm_area_struct *start, unsigned long limit) Seems like an unnecessary >80 column line ... static inline void unlock_range(struct vm_area_struct *start, unsigned long limit)