From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95FAC43460 for ; Mon, 10 May 2021 23:17:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D182561613 for ; Mon, 10 May 2021 23:17:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D182561613 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 100676B006E; Mon, 10 May 2021 19:17:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AFB76B0071; Mon, 10 May 2021 19:17:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E93A66B0072; Mon, 10 May 2021 19:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id C960B6B006E for ; Mon, 10 May 2021 19:17:46 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 79ED1181AF5FD for ; Mon, 10 May 2021 23:17:46 +0000 (UTC) X-FDA: 78126885732.36.B5F1DFF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 5A563E000113 for ; Mon, 10 May 2021 23:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BW26sTae1TuwCrPQcAIuja8vE5ngJppHhl5QwuMgUgw=; b=RBQ1JR4S5T9WsAErivz3mXmyXq 61FxgaT5cOHkvLW3xNizmRJGm4V9/KLa0xEdSTh5bY6ek/9bPJQ8zA9tPevkS00PSO7tk7SmyYww7 yyY9EpJ/aMkCihtFa+ng+GeP1+4YnEbqSqInLTmG8EhFusn2LegxT3pnHh5Num6Rg3sapJZc2vjC6 3mGftV02NZOdzabpzAnBp3diTC2dZNPsY+4mh/GL2+TacmSJOvqYcTTM0beOPrnVHcHliL+fZNvuJ HVoM+9ZcQQAqa0irZBrRs9sKGPw3Q+GFbm2FiVx/nUaAc+cbHlwQkqUpZi4zHUyEZtjyJAohGnO3Z mqq8XEVQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lgF9I-006fzl-UW; Mon, 10 May 2021 23:17:22 +0000 Date: Tue, 11 May 2021 00:17:16 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] mm/filemap: Fix readahead return types Message-ID: References: <20210510201201.1558972-1-willy@infradead.org> <20210510222756.GI8582@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210510222756.GI8582@magnolia> Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RBQ1JR4S; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5A563E000113 X-Stat-Signature: 1hzas7kbdnwssx3xnz4ircnihb7d15k5 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf13; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620688650-859018 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 10, 2021 at 03:27:56PM -0700, Darrick J. Wong wrote: > On Mon, May 10, 2021 at 09:12:01PM +0100, Matthew Wilcox (Oracle) wrote: > > A readahead request will not allocate more memory than can be represented > > by a size_t, even on systems that have HIGHMEM available. Change the > > length functions from returning an loff_t to a size_t. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Looks reasonable to me; is this a 5.13 bugfix or just something that > doesn't look right (i.e. save it for 5.14)? > > Reviewed-by: Darrick J. Wong Thanks! Linus was unhappy about it, and I promised to fix it. I leave it up to Andrew whether he wants to see this in 5.13 or 5.14. https://lore.kernel.org/linux-btrfs/CAHk-=wj1KRvb=hie1VUTGo1D_ckD+Suo0-M2Nh5Kek1Wu=2Ppw@mail.gmail.com/ (I went a little beyond what he was directly unhappy with and reviewed all the readahead.*length users for unnecessary loff_t usage)