From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mm/filemap: Fix readahead return types
Date: Tue, 11 May 2021 00:17:16 +0100 [thread overview]
Message-ID: <YJm+/IFdA4xe1oie@casper.infradead.org> (raw)
In-Reply-To: <20210510222756.GI8582@magnolia>
On Mon, May 10, 2021 at 03:27:56PM -0700, Darrick J. Wong wrote:
> On Mon, May 10, 2021 at 09:12:01PM +0100, Matthew Wilcox (Oracle) wrote:
> > A readahead request will not allocate more memory than can be represented
> > by a size_t, even on systems that have HIGHMEM available. Change the
> > length functions from returning an loff_t to a size_t.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Looks reasonable to me; is this a 5.13 bugfix or just something that
> doesn't look right (i.e. save it for 5.14)?
>
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks! Linus was unhappy about it, and I promised to fix it. I leave
it up to Andrew whether he wants to see this in 5.13 or 5.14.
https://lore.kernel.org/linux-btrfs/CAHk-=wj1KRvb=hie1VUTGo1D_ckD+Suo0-M2Nh5Kek1Wu=2Ppw@mail.gmail.com/
(I went a little beyond what he was directly unhappy with and reviewed
all the readahead.*length users for unnecessary loff_t usage)
prev parent reply other threads:[~2021-05-10 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 20:12 Matthew Wilcox (Oracle)
2021-05-10 22:27 ` Darrick J. Wong
2021-05-10 23:17 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJm+/IFdA4xe1oie@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=djwong@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox