From: Matthew Wilcox <willy@infradead.org>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>, Mel Gorman <mgorman@suse.de>,
Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@suse.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 2/2] mm/vmalloc: Print a warning message first on failure
Date: Sun, 9 May 2021 20:47:12 +0100 [thread overview]
Message-ID: <YJg8QO2JXm0+8UH6@casper.infradead.org> (raw)
In-Reply-To: <20210509193844.2562-2-urezki@gmail.com>
On Sun, May 09, 2021 at 09:38:44PM +0200, Uladzislau Rezki (Sony) wrote:
> export KBUILD_USERCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes \
> - -O2 -fomit-frame-pointer -std=gnu89
> + -O0 -g -fomit-frame-pointer -std=gnu89
You clearly didn't intend to submit this portion ...
> +++ b/mm/vmalloc.c
> @@ -2781,11 +2781,11 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
> }
>
> if (!area->pages) {
> - free_vm_area(area);
> warn_alloc(gfp_mask, NULL,
> "vmalloc size %lu allocation failure: "
> "page array size %lu allocation failed",
> nr_small_pages * PAGE_SIZE, array_size);
> + free_vm_area(area);
> return NULL;
> }
I think this is a bad idea. We're clearly low on memory (a memory
allocation just failed). We should free the memory we have allocated
to improve the chances of the warning message making it out.
next prev parent reply other threads:[~2021-05-09 19:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 19:38 [PATCH v2 1/2] mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node() Uladzislau Rezki (Sony)
2021-05-09 19:38 ` [PATCH v2 2/2] mm/vmalloc: Print a warning message first on failure Uladzislau Rezki (Sony)
2021-05-09 19:46 ` Uladzislau Rezki
2021-05-09 19:47 ` Matthew Wilcox [this message]
2021-05-09 20:05 ` Uladzislau Rezki
2021-05-09 20:18 ` Matthew Wilcox
2021-05-09 21:26 ` Uladzislau Rezki
2021-05-10 10:33 ` Uladzislau Rezki
2021-05-11 1:52 ` Andrew Morton
2021-05-11 1:58 ` Matthew Wilcox
2021-05-11 12:43 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJg8QO2JXm0+8UH6@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=npiggin@gmail.com \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox