From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE83FC433ED for ; Fri, 7 May 2021 13:31:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0BEB26143F for ; Fri, 7 May 2021 13:31:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BEB26143F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 132C58D0013; Fri, 7 May 2021 09:31:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E3708D0011; Fri, 7 May 2021 09:31:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13C38D0013; Fri, 7 May 2021 09:31:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id D90538D0011 for ; Fri, 7 May 2021 09:31:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8FBBB909D for ; Fri, 7 May 2021 13:31:17 +0000 (UTC) X-FDA: 78114521394.19.E3AD9BD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 95D094080F46 for ; Fri, 7 May 2021 13:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:To:From:Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=UlpgVzi5BmGTbt4d4TWs/kq0IhUBCME9k19bQzbuQwo=; b=NJ6CZFbewLzJ5V2RpXnRUWkYrV wpnRkSk6HyGF4bHtHKAX2t7+/I9N5Kcjdkav0RLdcSkmZdZXjYIdwxR3tBRMj2BXXgP0KaPvTHLv9 W5KuSffKV63mffujxZ0PeBks6aGMJF2LBfKGIfE0O1ISQM16mdHrD6Mt+NkN3smCN4UjHl7UdcLbu wZfjRsqPhoLiXSuJXZdMgCvrDyV7sK4Yv4Y45BwqKuKugks0+LHTAkfMSTuJ4vKmg55jLTAAEHFSz rE92A0qsUhQcmIsne4jX8ioz3kWMhFPT3WLdDZ4PGlxfgYpEGT0NEuqxLHq3yaIUQ0SAixFldodb3 zupY4i8Q==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lf0ZK-003D18-Pw for linux-mm@kvack.org; Fri, 07 May 2021 13:31:06 +0000 Date: Fri, 7 May 2021 14:31:02 +0100 From: Matthew Wilcox To: linux-mm@kvack.org Subject: Migrate (from, to) or (to, from)? Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 95D094080F46 X-Stat-Signature: mqwotzzktep6f4xrp5j8qcnzah3woocc Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NJ6CZFbe; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620394243-679973 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A survey: include/linux/page_owner.h:static inline void copy_page_owner(struct page *oldpage, struct page *newpage) mm/migration.c: void remove_migration_ptes(struct page *old, struct page *new, bool locked) int migrate_page_move_mapping(struct address_space *mapping, struct page *newpage, struct page *page, int extra_count) int migrate_huge_page_move_mapping(struct address_space *mapping, struct page *newpage, struct page *page) void migrate_page_states(struct page *newpage, struct page *page) void migrate_page_copy(struct page *newpage, struct page *page) int migrate_page(struct address_space *mapping, struct page *newpage, struct page *page, enum migrate_mode mode) int buffer_migrate_page(struct address_space *mapping, struct page *newpage, struct page *page, enum migrate_mode mode) int buffer_migrate_page_norefs(struct address_space *mapping, struct page *newpage, struct page *page, enum migrate_mode mode) rc = mapping->a_ops->migratepage(mapping, newpage, page, mode); That's a pretty clear preference for (to, from), so I'm going to change copy_page_owner() when I convert it to folio_copy_owner(). And I'll fix remove_migration_ptes() when i convert that to folios.