From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFDE3C433B4 for ; Fri, 14 May 2021 21:00:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C8B361401 for ; Fri, 14 May 2021 21:00:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C8B361401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E25666B0036; Fri, 14 May 2021 17:00:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD5986B006E; Fri, 14 May 2021 17:00:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27A56B0070; Fri, 14 May 2021 17:00:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 918A46B0036 for ; Fri, 14 May 2021 17:00:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 320279409 for ; Fri, 14 May 2021 21:00:38 +0000 (UTC) X-FDA: 78141055356.05.5B2F625 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf09.hostedemail.com (Postfix) with ESMTP id C0D906000101 for ; Fri, 14 May 2021 21:00:36 +0000 (UTC) Received: by mail-il1-f171.google.com with SMTP id e14so859783ils.12 for ; Fri, 14 May 2021 14:00:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TeLhWehijG54mouce8ikq7VtYZj7/i4EvjKXhny3Jfo=; b=qAmBxl09tLC4+mg6FsPdAzIzbTG5sYfLQVAm4f7Jo7aUl9sBCLHHhdrav0aEYOqLJ+ eWg5v0Za3xqeu9JFHADE210oSeG8TAMsk5TtINPDaD33FdX0J+wbR5OtKO+Cq26gnaIK M2n96TyYyNJvuo/scoD8kFKEyx/LnKHBeKKRNNWGG3XXMbW+ftJXqxJtXDFpoKHRzw51 /spv2njsdclX2WWF/uvephJ52O0mW2euz5MXxnTXFf+rGnOyr37Klv+gQceQhdkI4xBU rkW/cgPClMw7tEeOzEYBF1x4LQrOgiy7Jy3EJDvStx2HP7NV0NkLoBDUfxOd5OkGOXcC 52TA== X-Gm-Message-State: AOAM531ckw849RPmOAXcPuD1a83Q4KptvSMxtxMLPl9CIVtZF92awNnF cUfRyShc5dpE7usKmLx0fJQ= X-Google-Smtp-Source: ABdhPJyXHLR18z9BtQ5R8acjjU7PO+hmO2IzJ2vd1o3DUpSbN0+MoCAa3c70t6m0+yZfR8ehgrRZsw== X-Received: by 2002:a92:510:: with SMTP id q16mr28805400ile.41.1621026037202; Fri, 14 May 2021 14:00:37 -0700 (PDT) Received: from google.com (243.199.238.35.bc.googleusercontent.com. [35.238.199.243]) by smtp.gmail.com with ESMTPSA id s14sm3560458ilj.14.2021.05.14.14.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 14:00:36 -0700 (PDT) Date: Fri, 14 May 2021 21:00:35 +0000 From: Dennis Zhou To: Wei Yongjun Cc: Tejun Heo , Christoph Lameter , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] percpu: make symbol 'pcpu_free_slot' static Message-ID: References: <20210514063952.3240527-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514063952.3240527-1-weiyongjun1@huawei.com> X-Rspamd-Queue-Id: C0D906000101 Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-Rspamd-Server: rspam03 X-Stat-Signature: fid5tohomy8cfmkjj7yoweu1h7db93ux X-HE-Tag: 1621026036-810783 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Fri, May 14, 2021 at 06:39:52AM +0000, Wei Yongjun wrote: > The sparse tool complains as follows: > > mm/percpu.c:138:5: warning: > symbol 'pcpu_free_slot' was not declared. Should it be static? > > This symbol is not used outside of percpu.c, so marks it static. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > mm/percpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/percpu.c b/mm/percpu.c > index a257c3efdf18..73c249f3b6a3 100644 > --- a/mm/percpu.c > +++ b/mm/percpu.c > @@ -135,7 +135,7 @@ static int pcpu_unit_size __ro_after_init; > static int pcpu_nr_units __ro_after_init; > static int pcpu_atom_size __ro_after_init; > int pcpu_nr_slots __ro_after_init; > -int pcpu_free_slot __ro_after_init; > +static int pcpu_free_slot __ro_after_init; > int pcpu_sidelined_slot __ro_after_init; > int pcpu_to_depopulate_slot __ro_after_init; > static size_t pcpu_chunk_struct_size __ro_after_init; > Ah that's my bad. I've applied this for-5.14. Thanks, Dennis