From: Roman Gushchin <guro@fb.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>, Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Greg Thelen <gthelen@google.com>,
Dragos Sbirlea <dragoss@google.com>,
Priya Duraisamy <padmapriyad@google.com>
Subject: Re: [RFC] memory reserve for userspace oom-killer
Date: Wed, 21 Apr 2021 12:04:05 -0700 [thread overview]
Message-ID: <YIB3JYHvnuOi4CIt@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <CALvZod7x=QR=p73BAxWPbFm+V8KFwYCcxNp-bOBvGaAttxjm7g@mail.gmail.com>
On Wed, Apr 21, 2021 at 06:26:37AM -0700, Shakeel Butt wrote:
> On Tue, Apr 20, 2021 at 7:58 PM Roman Gushchin <guro@fb.com> wrote:
> >
> [...]
> > >
> > > Michal has suggested ALLOC_OOM which is less risky.
> >
> > The problem is that even if you'll serve the oom daemon task with pages
> > from a reserve/custom pool, it doesn't guarantee anything, because the task
> > still can wait for a long time on some mutex, taken by another process,
> > throttled somewhere in the reclaim.
>
> I am assuming here by mutex you are referring to locks which
> oom-killer might have to take to read metrics or any possible lock
> which oom-killer might have to take which some other process can take
> too.
>
> Have you observed this situation happening with oomd on production?
I'm not aware of any oomd-specific issues. I'm not sure if they don't exist
at all, but so far it's wasn't a problem for us. Maybe it because you tend to
have less pagecache (as I understand), maybe it comes to specific oomd
policies/settings.
I know we had different pains with mmap_sem and atop and similar programs,
where reading process data stalled on mmap_sem for a long time.
Thanks!
next prev parent reply other threads:[~2021-04-21 19:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 1:44 Shakeel Butt
2021-04-20 6:45 ` Michal Hocko
2021-04-20 16:04 ` Shakeel Butt
2021-04-21 7:16 ` Michal Hocko
2021-04-21 13:57 ` Shakeel Butt
2021-04-21 14:29 ` Michal Hocko
2021-04-22 12:33 ` [RFC PATCH] Android OOM helper proof of concept peter enderborg
2021-04-22 13:03 ` Michal Hocko
2021-05-05 0:37 ` [RFC] memory reserve for userspace oom-killer Shakeel Butt
2021-05-05 1:26 ` Suren Baghdasaryan
2021-05-05 2:45 ` Shakeel Butt
2021-05-05 2:59 ` Suren Baghdasaryan
2021-05-05 2:43 ` Hillf Danton
2021-04-20 19:17 ` Roman Gushchin
2021-04-20 19:36 ` Suren Baghdasaryan
2021-04-21 1:18 ` Shakeel Butt
2021-04-21 2:58 ` Roman Gushchin
2021-04-21 13:26 ` Shakeel Butt
2021-04-21 19:04 ` Roman Gushchin [this message]
2021-04-21 7:23 ` Michal Hocko
2021-04-21 14:13 ` Shakeel Butt
2021-04-21 17:05 ` peter enderborg
2021-04-21 18:28 ` Shakeel Butt
2021-04-21 18:46 ` Peter.Enderborg
2021-04-21 19:18 ` Shakeel Butt
2021-04-22 5:38 ` Peter.Enderborg
2021-04-22 14:27 ` Shakeel Butt
2021-04-22 15:41 ` Peter.Enderborg
2021-04-22 13:08 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIB3JYHvnuOi4CIt@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dragoss@google.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=padmapriyad@google.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox