From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A79C433ED for ; Fri, 16 Apr 2021 15:20:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69C1E61166 for ; Fri, 16 Apr 2021 15:20:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69C1E61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E22206B0036; Fri, 16 Apr 2021 11:20:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD0A56B006C; Fri, 16 Apr 2021 11:20:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C72656B0070; Fri, 16 Apr 2021 11:20:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id AA9616B0036 for ; Fri, 16 Apr 2021 11:20:53 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 33BDF3ABE for ; Fri, 16 Apr 2021 15:20:53 +0000 (UTC) X-FDA: 78038592786.39.9197152 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf21.hostedemail.com (Postfix) with ESMTP id 74DD7E00012D for ; Fri, 16 Apr 2021 15:20:50 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id f19so11483252qka.8 for ; Fri, 16 Apr 2021 08:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vJQzDyPMzRCR3Pj66zSN4Mp2TuH3DXRBeVPYYvWoKrU=; b=uEKYeSNXrs0vvy9Juj5zS5C4UGxfquZmEwu9JoW5KpfTcfCHeCtkFbqIiVnFqv4n1m 6GPV/7cnX9H9daoTZHsDYLZC/9P89NumjGeKNXhrqm+i4ErxteTIZxdXgqIhxYPJw0QX BJOhfLNXfzZjE0lN2V9R6M6uOnyWXieqY2wCh1LNziVouc59fcrDODJbLIiQ62La2+YC FkGGQPSMMjnHIFktdRH+Nhdk16hG28vH1LHYKEcbEtDr0EY/2maOggPIWETx8NKfcrHs iq5bsLelijNu3aUF0D3WYUglqbZRXgkJTszbpCW0QgGfoeipKRTaZ0drVNOatoDOob8a Gojw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vJQzDyPMzRCR3Pj66zSN4Mp2TuH3DXRBeVPYYvWoKrU=; b=VLdgEvhWKAnenUW6kvMlRxZuf4ApgoJGz+VVDeBsDqSsRlh1JNk921q4SxXDhQcZRG eev9pD2bnSUOL6h07jYjZm1BYi/0YntD3ySHCc5oYDyO7mUw+dADHiSqDH5uZXQ473we 7i9GCRDqfwkbmV1E0fNS/faNjfeYaGODeRAVPTs0EPynyzvcQczEWI8Rm2PtlbggK7Md Jdu7eWSPeV1NOfnnk4qAfgBFZ7GXTBsLVhBOqZg1rim1YfgDGcpi+arT1ekLcxYGPBmo cFOH8n6h+T5QEzJVvmISIgAD0WZertK77BL4NbdUnHWhoDaCw9A2AKEtRzvJj6/ukhzx KOTw== X-Gm-Message-State: AOAM530NBHMtV49wOpUXa3EFAkG/RMiL+rX6oPu0//TrFzpGTVzLvdj8 PROhgPoqewyOP8SEfSWks8Pe+g== X-Google-Smtp-Source: ABdhPJzS50rG84nFsNhmYFRBrJz0q3QKdkqei7X0wdsmuaffsPY8xFLGy5knA6Iix4oozzqyZBJnvw== X-Received: by 2002:a05:620a:22a5:: with SMTP id p5mr9275130qkh.480.1618586451806; Fri, 16 Apr 2021 08:20:51 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id w4sm4393844qkd.94.2021.04.16.08.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 08:20:50 -0700 (PDT) Date: Fri, 16 Apr 2021 11:20:49 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com Subject: Re: [PATCH v2 5/8] mm: memcontrol: rename lruvec_holds_page_lru_lock to page_matches_lruvec Message-ID: References: <20210416051407.54878-1-songmuchun@bytedance.com> <20210416051407.54878-6-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416051407.54878-6-songmuchun@bytedance.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 74DD7E00012D X-Stat-Signature: f96u1ipeu85apdya9xozqw8jethbrz6m Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-qk1-f175.google.com; client-ip=209.85.222.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618586450-175050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 16, 2021 at 01:14:04PM +0800, Muchun Song wrote: > lruvec_holds_page_lru_lock() doesn't check anything about locking and is > used to check whether the page belongs to the lruvec. So rename it to > page_matches_lruvec(). > > Signed-off-by: Muchun Song The rename makes sense, since the previous name was defined by a specific use case rather than what it does. That said, it did imply a lock context that makes the test result stable. Without that the function could use a short comment, IMO. How about: /* Test requires a stable page->memcg binding, see page_memcg() */ With that, Acked-by: Johannes Weiner