From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE442C433B4 for ; Fri, 16 Apr 2021 12:14:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43ECD61184 for ; Fri, 16 Apr 2021 12:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43ECD61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD56B6B0036; Fri, 16 Apr 2021 08:14:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84576B006C; Fri, 16 Apr 2021 08:14:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D62B6B0070; Fri, 16 Apr 2021 08:14:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id 6FB9B6B0036 for ; Fri, 16 Apr 2021 08:14:12 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3018E1E11 for ; Fri, 16 Apr 2021 12:14:12 +0000 (UTC) X-FDA: 78038122344.39.06D1B7E Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf16.hostedemail.com (Postfix) with ESMTP id 0C41E80192EF for ; Fri, 16 Apr 2021 12:14:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5EEB0B035; Fri, 16 Apr 2021 12:14:10 +0000 (UTC) Date: Fri, 16 Apr 2021 14:14:04 +0200 From: Oscar Salvador To: Baoquan He Cc: Andrew Morton , Mike Kravetz , Vlastimil Babka , David Hildenbrand , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH v9 5/7] mm: Make alloc_contig_range handle free hugetlb pages Message-ID: References: <20210416070023.4742-1-osalvador@suse.de> <20210416070023.4742-6-osalvador@suse.de> <20210416094920.GA8560@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416094920.GA8560@MiWiFi-R3L-srv> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0C41E80192EF X-Stat-Signature: g8zqfenzeadi8ti9ejzztgsbhisey6kz Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1618575250-824504 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 16, 2021 at 05:49:20PM +0800, Baoquan He wrote: > On 04/16/21 at 09:00am, Oscar Salvador wrote: > ... > > +/* > > + * alloc_and_dissolve_huge_page - Allocate a new page and dissolve the old one > > + * @h: struct hstate old page belongs to > > + * @old_page: Old page to dissolve > > + * Returns 0 on success, otherwise negated error. > > + */ > > +static int alloc_and_dissolve_huge_page(struct hstate *h, struct page *old_page) > > +{ > > + gfp_t gfp_mask = htlb_alloc_mask(h) | __GFP_THISNODE; > > + int nid = page_to_nid(old_page); > > + struct page *new_page; > > + int ret = 0; > > + > > + /* > > + * Before dissolving the page, we need to allocate a new one for the > > + * pool to remain stable. Using alloc_buddy_huge_page() allows us to > > + * not having to deal with prep_new_page() and avoids dealing of any > ~ prep_new_huge_page() ? Yep, clumsy. @Andrew: could you please amend that or should I send a new version? Thanks -- Oscar Salvador SUSE L3