From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1640EC433ED for ; Thu, 15 Apr 2021 16:57:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70488611AC for ; Thu, 15 Apr 2021 16:57:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70488611AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB8E96B0036; Thu, 15 Apr 2021 12:57:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C67CF6B006C; Thu, 15 Apr 2021 12:57:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1C16B0070; Thu, 15 Apr 2021 12:57:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 91E766B0036 for ; Thu, 15 Apr 2021 12:57:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4DF5B5827 for ; Thu, 15 Apr 2021 16:57:56 +0000 (UTC) X-FDA: 78035208552.05.DD8BA4B Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf29.hostedemail.com (Postfix) with ESMTP id CF875D2 for ; Thu, 15 Apr 2021 16:57:53 +0000 (UTC) Received: by mail-qv1-f42.google.com with SMTP id bs7so11526413qvb.12 for ; Thu, 15 Apr 2021 09:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8CoVbt6IzeLUC5q7IpdX1He4bycqg82PFofNsjY3nlo=; b=dz805Z+hx47wOwNMrHi3cTS4DU3UR/WoK/LOkLO4wjGFRvU0R2UR/LM1Jr5qmO+UfX Xj8eZgLigKlOmHDihOrF/lge4KjH4S1MbzQ1M0phjbomNKF4n6kf/MMrGg1Ou+v4T6oN hKy0W1m35ceAeVYDrHWoHULB41E5JJZzzI3D2kUw76zXNtQ3bamQFVNjksr5O8mNKpMf 4W4khLTCWvVPTlyDZi5xBNYSSFRlRicGN+SQevM04Aa6pNLQ7jNhYYrcky177RipPj2F 3TdlR6C9GSq2z9Q4NoV8m/FUwzOffvwttLpLK7cohfEQM759tvqvn+nzZANak8XsuIDd EQrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8CoVbt6IzeLUC5q7IpdX1He4bycqg82PFofNsjY3nlo=; b=gT1DoZkeTew6lxpzCdiLmbYzODPM7W+dIDhkFR8o7G0xH0yZATw8d6eaG6xlEiD6y7 0NaYCviQJTp+6p7Obf5YsU0++ETiGSsyxqYz6CiNGjjZ6ClkUqC0QKAaCkA/Ds2TaMhF cQV+qIuohF+VP/AHwQ8rhz8Ncq8sAnsXRmpmTqhcQ6GSs8AdRmBToPTW44Jno72LymGS h3bjG+HLiIyeJph44mLMWoV7SqHN6XNR/+bVfwMHsjC2j4AQlQpvuiaVNgirSXyZjV2+ NtglnJjjLFpG2WqP6Lb8Uy1ZTnnFf19I2kAShAivPWTV/rWXlmM810zbqhpGE8bzOkLi FGnQ== X-Gm-Message-State: AOAM531szMeu6CkQNPKuQVFjwy5p5LMBbyOdrwaaoVv3OvNCOwHS6SrH 1RD/FJM0Zz1e0FgVgWIyLI6vcw== X-Google-Smtp-Source: ABdhPJwrkekqqLUelsmYQNbOIN/gwIAcnSZuH7n7IbRPMrei060BZIN2tzys9aDf7QbjTGMb0PIRKQ== X-Received: by 2002:a05:6214:ca4:: with SMTP id s4mr4142968qvs.44.1618505874966; Thu, 15 Apr 2021 09:57:54 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id a202sm2402124qkc.13.2021.04.15.09.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 09:57:54 -0700 (PDT) Date: Thu, 15 Apr 2021 12:57:53 -0400 From: Johannes Weiner To: Waiman Long Cc: Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun Subject: Re: [PATCH v3 4/5] mm/memcg: Separate out object stock data into its own struct Message-ID: References: <20210414012027.5352-1-longman@redhat.com> <20210414012027.5352-5-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414012027.5352-5-longman@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CF875D2 X-Stat-Signature: saep5bhobj8sapc55rhewjtbd1i93849 Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-qv1-f42.google.com; client-ip=209.85.219.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618505873-165579 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 09:20:26PM -0400, Waiman Long wrote: > The object stock data stored in struct memcg_stock_pcp are independent > of the other page based data stored there. Separating them out into > their own struct to highlight the independency. > > Signed-off-by: Waiman Long > Acked-by: Roman Gushchin > Reviewed-by: Shakeel Butt > --- > mm/memcontrol.c | 41 ++++++++++++++++++++++++++--------------- > 1 file changed, 26 insertions(+), 15 deletions(-) It's almost twice more code, and IMO not any clearer. Plus it adds some warts: int dummy[0], redundant naming in stock->obj.cached_objcg, this_cpu_ptr() doesn't really need a wrapper etc.