From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D7CC433B4 for ; Wed, 14 Apr 2021 04:54:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 51707611F2 for ; Wed, 14 Apr 2021 04:54:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51707611F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D76EC6B0036; Wed, 14 Apr 2021 00:54:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC746B006C; Wed, 14 Apr 2021 00:54:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63A16B0070; Wed, 14 Apr 2021 00:54:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 938BC6B0036 for ; Wed, 14 Apr 2021 00:54:27 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3587C46784A6 for ; Wed, 14 Apr 2021 04:54:27 +0000 (UTC) X-FDA: 78029756574.35.7FC8828 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf03.hostedemail.com (Postfix) with ESMTP id 7ABA3C0007C1 for ; Wed, 14 Apr 2021 04:54:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B958DB01D; Wed, 14 Apr 2021 04:54:25 +0000 (UTC) Date: Wed, 14 Apr 2021 06:54:23 +0200 From: Oscar Salvador To: Mike Kravetz Cc: Andrew Morton , Vlastimil Babka , David Hildenbrand , Michal Hocko , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 5/7] mm: Make alloc_contig_range handle free hugetlb pages Message-ID: References: <20210413104747.12177-1-osalvador@suse.de> <20210413104747.12177-6-osalvador@suse.de> <338f73f5-cff6-61c1-5252-01d9b30be627@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <338f73f5-cff6-61c1-5252-01d9b30be627@oracle.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7ABA3C0007C1 X-Stat-Signature: h1jyaq3iaqned1dnw4okq5pgosmxyte5 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1618376063-618062 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 03:29:02PM -0700, Mike Kravetz wrote: > > spin_lock_irq(hugetlb_lock) > > 1) update_and_free_page > > PageHuge() == F > > __free_pages() > > 2) enqueue_huge_page > > SetPageHugeFreed() > > spin_unlock(&hugetlb_lock) > > Very small nit, the above should be spin_unlock_irq(&hugetlb_lock) Right, I missed it somehow. > > + /* > > + * The page might have been dissolved from under our feet, so make sure > > + * to carefully check the state under the lock. > > + * Return success when racing as if we dissolved the page ourselves. > > + */ > > + spin_lock_irq(&hugetlb_lock); > > + if (PageHuge(page)) { > > + head = compound_head(page); > > + h = page_hstate(head); > > + } else { > > + spin_unlock(&hugetlb_lock); > > Should be be spin_unlock_irq(&hugetlb_lock); > > Other than that, it looks good. Yeah, I will amend it in the next version. Thanks Mike! -- Oscar Salvador SUSE L3