From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BFDC433B4 for ; Tue, 13 Apr 2021 18:03:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 907FC613B1 for ; Tue, 13 Apr 2021 18:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 907FC613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 196706B0073; Tue, 13 Apr 2021 14:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E396B0074; Tue, 13 Apr 2021 14:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F29D56B0075; Tue, 13 Apr 2021 14:03:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id D331B6B0073 for ; Tue, 13 Apr 2021 14:03:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8A3AE8248D51 for ; Tue, 13 Apr 2021 18:03:08 +0000 (UTC) X-FDA: 78028115256.01.865CEB5 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 14A752000273 for ; Tue, 13 Apr 2021 18:03:08 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id dp18so3886113qvb.5 for ; Tue, 13 Apr 2021 11:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NSrJ5NIY0R4389SCMTdtOH8upYr0YvZv/ZgSkyJwyus=; b=VnpjPcAGmH3B9oaraFs5c3At2DlWv6qrUX0ktFGyFlB0FUeEGDHv5lfQ51Pt+dW72N ovX9zOE5BBcUoqpsXHc1Vp/eOyblW+U8xleT7HkJrzz1d54XY3Jlp/arzyDaRF38E1sB CUDEMnzh2lsV4Zw3975pXCrtg9uSf7pUIOtR+6C0izW9YO/+qqUkvouSsmlIRdKQGkka gA0yi+N7kA/SHj3FZ1qznjUjJz4bYj9nUQ+yqgB48YqYGTyWkDbkM3vkowchepbq7FWu QQ6QsdfNyPXYzd2D6c41nQCVF4eYeIQc5RQx9GPhCWFNrGZLgQf3z2JZGQe1KmiKC2uO W0/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NSrJ5NIY0R4389SCMTdtOH8upYr0YvZv/ZgSkyJwyus=; b=XCHEydvPJ/ciVLGMeWwwnOXX6tgPM0bzw0Xdr73k0WwKiBcj5To4jIbokyAEmHSE/i O9URhOys3PaThFE1JqvlSrzahk/41i7Q/ZM0i4vTm1TSK4yXQK/XwwmD6Rgu/Xge47yn YP/map+d/GyB3QD7IPzqQ4hVPGvbRst9nbZiTjBt/7bKPUIgaayWVHWtYyxt9r5Vb9rZ SkqzGTI4BQTiIfViBJqd7GGcoDhuWOMbopbGc6F31aXFPqN/lBl7IEX37CU5/RDNQ1aD /AK1tHh+a3xw2Ox29yG7gwYVGAngWKVUPnme98PuT4/nHeKfUFFfRfqdEksHMZ0Um+Ed /9tg== X-Gm-Message-State: AOAM533qDIuZsMKZ/9OYr6Wf2rT3hhkDeVT239NRZU1EJOXUfyqhDhjC 5AGPa7Or/NWozUbIE1j9BYLBYg== X-Google-Smtp-Source: ABdhPJz897Dcw3QPB8/7AWf305sGrYBRKU9lOl2NXYK+bX8SGJpHrb+P3XTKLHzq/UfsXEc9GGHlRw== X-Received: by 2002:a05:6214:ca4:: with SMTP id s4mr33985788qvs.44.1618336985771; Tue, 13 Apr 2021 11:03:05 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:216d]) by smtp.gmail.com with ESMTPSA id v6sm10188142qkf.132.2021.04.13.11.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 11:03:05 -0700 (PDT) Date: Tue, 13 Apr 2021 14:03:04 -0400 From: Johannes Weiner To: Muchun Song Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com Subject: Re: [PATCH 6/7] mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock Message-ID: References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-7-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413065153.63431-7-songmuchun@bytedance.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 14A752000273 X-Stat-Signature: eg7pywtj3qfrg7ayeret8s1k7dozdt95 Received-SPF: none (cmpxchg.org>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-qv1-f44.google.com; client-ip=209.85.219.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618336988-443381 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 13, 2021 at 02:51:52PM +0800, Muchun Song wrote: > The css_set_lock is used to guard the list of inherited objcgs. So there > is no need to uncharge kernel memory under css_set_lock. Just move it > out of the lock. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner