From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE58C433B4 for ; Tue, 13 Apr 2021 13:24:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C75461369 for ; Tue, 13 Apr 2021 13:24:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C75461369 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 961D66B0036; Tue, 13 Apr 2021 09:24:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9126D6B006E; Tue, 13 Apr 2021 09:24:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8005C6B0070; Tue, 13 Apr 2021 09:24:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 64F9A6B0036 for ; Tue, 13 Apr 2021 09:24:36 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 22B2E82499B9 for ; Tue, 13 Apr 2021 13:24:36 +0000 (UTC) X-FDA: 78027413352.03.3B95C49 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP id C534F40002D3 for ; Tue, 13 Apr 2021 13:24:20 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618320274; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AgVgfP+J7DIBhEv0CRZ/1Mun/+0vSfjv/jkjrg7B9aA=; b=ZLCIQLgVhVDJuQBBuZxQrHH+/v2GCz5xa0StiXPdClg0F1j3mfMKNxZgEeou9w05tQ/8ir P9urlNZamiktMw5QXM+wyypiIMoFfiK49b9l8PdHpC5/dHK5nIkfkCgZdpB9p7VyVlZeMO QuKljz5eF9nkwTdan8pjiYs9GNnGvnA= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A46CEAE89; Tue, 13 Apr 2021 13:24:34 +0000 (UTC) Date: Tue, 13 Apr 2021 15:24:32 +0200 From: Michal Hocko To: Oscar Salvador Cc: Andrew Morton , Mike Kravetz , Vlastimil Babka , David Hildenbrand , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality Message-ID: References: <20210413104747.12177-1-osalvador@suse.de> <20210413104747.12177-5-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413104747.12177-5-osalvador@suse.de> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C534F40002D3 X-Stat-Signature: xt4ekxzrjumpnedxwb33hjxnx3des331 Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618320260-404599 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000160, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 13-04-21 12:47:44, Oscar Salvador wrote: [...] > +static void prep_new_huge_page(struct hstate *h, struct page *page, int nid) > +{ > + __prep_new_huge_page(page); > spin_lock_irq(&hugetlb_lock); > - h->nr_huge_pages++; > - h->nr_huge_pages_node[nid]++; > + __prep_account_new_huge_page(h, nid); > spin_unlock_irq(&hugetlb_lock); > } Any reason to decouple the locking from the accounting? > > -- > 2.16.3 -- Michal Hocko SUSE Labs