From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9281C433ED for ; Mon, 12 Apr 2021 09:20:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6578A61207 for ; Mon, 12 Apr 2021 09:20:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6578A61207 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F3FAC6B0036; Mon, 12 Apr 2021 05:20:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F15D86B006C; Mon, 12 Apr 2021 05:20:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDE836B006E; Mon, 12 Apr 2021 05:20:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id C2EBA6B0036 for ; Mon, 12 Apr 2021 05:20:58 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 862B88249980 for ; Mon, 12 Apr 2021 09:20:58 +0000 (UTC) X-FDA: 78023170596.39.D534134 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf25.hostedemail.com (Postfix) with ESMTP id CE51B600010B for ; Mon, 12 Apr 2021 09:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xSaLg0d5BnzMi4b4UK7QvM6+0Er5HobHZZa5u8XChI0=; b=J+wc8GvEHNZmuOhAFfHW4OCaFN MeoKZQIBEjEtLQAdhLso6IiRKRyH4zYgQLoEzlnihDBZk5DwXSg1WhEQCKsIsU5QTptf5PHVZPey3 xgyfjjrxvYuKhNue+/PLZVvil6Jzc2UstFi/bSg0ArGAu0Hmsf5HZ/a4OzYaVJ3NOeoUK8w+pDtWK URykpFynzzwRFZ+xq6EEIiDw9O7flo9ap+c1tMKW+j34Ujp5MOyrFPRycmxUvd3pDiTFG5AExmX98 3BYcv35I8jj0nh3QmkGn1JbfChn08Z65PNINCd91jBWD50kCNOaot8kqgOc7OC4Sk2YZ9NtPTZa9y JPTz5x9A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lVskP-006GEn-So; Mon, 12 Apr 2021 09:20:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 58982300033; Mon, 12 Apr 2021 11:20:45 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3DE4720224201; Mon, 12 Apr 2021 11:20:45 +0200 (CEST) Date: Mon, 12 Apr 2021 11:20:45 +0200 From: Peter Zijlstra To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, x86@kernel.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, chris@chris-wilson.co.uk, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, keescook@chromium.org Subject: Re: [PATCH 2/7] xen/gntdev,x86: Remove apply_to_page_range() use from module Message-ID: References: <20210412080012.357146277@infradead.org> <20210412080611.635125063@infradead.org> <20210412082640.GB4372@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412082640.GB4372@lst.de> X-Stat-Signature: rfdhjx7oug1teu74w43mqkm4hhgtn3et X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CE51B600010B Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=desiato.infradead.org; client-ip=90.155.92.199 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618219255-920300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 10:26:40AM +0200, Christoph Hellwig wrote: > On Mon, Apr 12, 2021 at 10:00:14AM +0200, Peter Zijlstra wrote: > > Instead of relying on apply_to_page_range() being available to > > modules, move its use into core kernel code and export it's > > application. > > This doesn't exactly look great, but at least it contains the damage.. That was just about as far as I got... > > NOTE: ideally we do: use_ptemod = !auto_translate_physmap && > > gnttab_map_avail_bits and remove this hack. > > Given how much pain the !auto_translate_physmap case causes all over > the kernel I wonder what a realistic timeline might be for dropping > support for this case might be.. I've no experience with any of that; it looks absolutely disguisting, all of it. I figured that's part of the Xen 'charm' :-)