From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F8CC433ED for ; Sat, 10 Apr 2021 00:11:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03D1E61105 for ; Sat, 10 Apr 2021 00:11:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03D1E61105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 944136B0036; Fri, 9 Apr 2021 20:11:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91A2A6B006E; Fri, 9 Apr 2021 20:11:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7942F6B0070; Fri, 9 Apr 2021 20:11:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 5C8536B0036 for ; Fri, 9 Apr 2021 20:11:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1A6BDB79E for ; Sat, 10 Apr 2021 00:11:52 +0000 (UTC) X-FDA: 78014529264.06.7B30EB1 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf25.hostedemail.com (Postfix) with ESMTP id E339A600010F for ; Sat, 10 Apr 2021 00:11:49 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id w7-20020a1cdf070000b0290125f388fb34so3070887wmg.0 for ; Fri, 09 Apr 2021 17:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fA8Z5aUUNElBHQmTl0rVRM8cCmxTfIGvqWZXobJvnWQ=; b=CtMvdE66Fm4dWjje6zKsz5kv72mdudXYT7IjWrKjKo1ElzVKNAsIxbE4ZKxunfPt2/ 8ie4/TsZVuhs4+43rmUlu+6M5YlxQlZEbyG1HgCeyhrzubvSiO1oRRhBFP93PkeXTXNQ aHTar9XiwUAq8rpKJmYWgPOZbUDWF22pGOe2uku4LffjB5xotLkIyhkxdoq9Mbkt9xnT e08O690WOfdvLNwLu8dTOPL9slPOPP4GCBz8q2w/IqHXGhvq71v3FiDWd63lPEpLH88S KqfyPamBXXC2iXxWp3jZZJH7Gg2oV2dtcUo55+5gXdpVcjJXcYI02ISu0xYho/CKXJaX CL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fA8Z5aUUNElBHQmTl0rVRM8cCmxTfIGvqWZXobJvnWQ=; b=akXGM3M+ISl4cJQUKcmBadyF4aaS0meqLilUO6xd8WflgJP2O9AW68KkiRm7Kl4jrw V3bQZSf9NPynEg44TPXOIFoIW3y/Wc4Cr78y8aIH9h5iJpGqGnEQHHazWe9M8MPtL1Zk FGYQF1LFGktN7MfOUmnUQKtXkAlYOEtrIRAVEoTIo56v2fsbMBdsOslMsaH+OBR9rRJi yr/kvx94MYW0auLzXO5SuCPtvRizEIbz0B5RqaEsyELwAK4nr/M70SwSlFbAg7RXItpW Zu+ethQpRMs9Yfwcn8V8+/H7ZO0Nav8nHoGvEx0+u6wzbw0jhuiOR1kebsoscHLkI21I J0AA== X-Gm-Message-State: AOAM533O2UguQ9qo9w7myYNLdsHz/NKCUIrRnCb3l4BuJ5Y2CiyhaeUx TJyZl7TtV3L0fLhrxvPigOG9Ng== X-Google-Smtp-Source: ABdhPJzAaP35Kiw87xpUTi5qQTsrRoBKS6TFnZdpjti+HlUXGZNQDuwqZCfg9FEauKEV6I1dmHPq2w== X-Received: by 2002:a7b:c38d:: with SMTP id s13mr15914875wmj.147.1618013510497; Fri, 09 Apr 2021 17:11:50 -0700 (PDT) Received: from apalos.home (ppp-94-65-225-75.home.otenet.gr. [94.65.225.75]) by smtp.gmail.com with ESMTPSA id p10sm6815210wmi.0.2021.04.09.17.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 17:11:50 -0700 (PDT) Date: Sat, 10 Apr 2021 03:11:45 +0300 From: Ilias Apalodimas To: Matteo Croce Cc: netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Michel Lespinasse , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Guoqing Jiang , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Aleksandr Nogikh , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni Subject: Re: [PATCH net-next v3 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: References: <20210409223801.104657-1-mcroce@linux.microsoft.com> <20210409223801.104657-4-mcroce@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409223801.104657-4-mcroce@linux.microsoft.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E339A600010F X-Stat-Signature: xpo49gxemg54jnb7strte4jt8wkqhwj5 Received-SPF: none (linaro.org>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail-wm1-f49.google.com; client-ip=209.85.128.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618013509-97582 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matteo, [...] > +bool page_pool_return_skb_page(void *data); > + > struct page_pool *page_pool_create(const struct page_pool_params *params); > > #ifdef CONFIG_PAGE_POOL > @@ -243,4 +247,13 @@ static inline void page_pool_ring_unlock(struct page_pool *pool) > spin_unlock_bh(&pool->ring.producer_lock); > } > > +/* Store mem_info on struct page and use it while recycling skb frags */ > +static inline > +void page_pool_store_mem_info(struct page *page, struct xdp_mem_info *mem) > +{ > + u32 *xmi = (u32 *)mem; > + I just noticed this changed from the original patchset I was carrying. On the original, I had a union containing a u32 member to explicitly avoid this casting. Let's wait for comments on the rest of the series, but i'd like to change that back in a v4. Aplogies, I completely missed this on the previous postings ... Thanks /Ilias