From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51954C433ED for ; Fri, 9 Apr 2021 12:48:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DBBE6610E7 for ; Fri, 9 Apr 2021 12:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBBE6610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6C18A6B0092; Fri, 9 Apr 2021 08:48:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6709C8D0002; Fri, 9 Apr 2021 08:48:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5121C6B0095; Fri, 9 Apr 2021 08:48:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 338A76B0092 for ; Fri, 9 Apr 2021 08:48:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E7CD41801813D for ; Fri, 9 Apr 2021 12:48:14 +0000 (UTC) X-FDA: 78012806508.19.EE393AA Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf25.hostedemail.com (Postfix) with ESMTP id 9A7CA600010F for ; Fri, 9 Apr 2021 12:48:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617972493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/cklqRtaAoBxj6T8zaOYaeYthIiew+7URzqJWSDV+A4=; b=nH5uQ/hzVZLcswwNjsuRUB8vnnaKjiKfQtjZmowow1wDF0qUEGQCeCAR60WiOWkCTvKm+n 4v2khlPRms4RgZrOmITu1wvBJGjG/gAETYXCvKez8A9Hpip+O40YRbRoFBFiLY0yCMJWQs HrwzP2axM2tCz+jYqaZ8ocm//DUGev0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3916DAFD8; Fri, 9 Apr 2021 12:48:13 +0000 (UTC) Date: Fri, 9 Apr 2021 14:48:12 +0200 From: Michal Hocko To: Mel Gorman Cc: Andrew Morton , Linux-MM , LKML , Oscar Salvador , "Michael S. Tsirkin" , David Hildenbrand , Vlastimil Babka , Alexander Duyck , Minchan Kim Subject: Re: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove Message-ID: References: <20210409120957.GM3697@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: fpdida89cz57hpacntmy3orfs6y1ghhy X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9A7CA600010F Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617972492-863325 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 09-04-21 14:42:58, Michal Hocko wrote: > On Fri 09-04-21 13:09:57, Mel Gorman wrote: > > zone_pcp_reset allegedly protects against a race with drain_pages > > using local_irq_save but this is bogus. local_irq_save only operates > > on the local CPU. If memory hotplug is running on CPU A and drain_pages > > is running on CPU B, disabling IRQs on CPU A does not affect CPU B and > > offers no protection. > > Yes, the synchronization aspect is bogus indeed. > > > This patch reorders memory hotremove such that the PCP structures > > relevant to the zone are no longer reachable by the time the structures > > are freed. With this reordering, no protection is required to prevent > > a use-after-free and the IRQs can be left enabled. zone_pcp_reset is > > renamed to zone_pcp_destroy to make it clear that the per-cpu structures > > are deleted when the function returns. > > Wouldn't it be much easier to simply not destroy/reset pcp of an empty > zone at all? The whole point of this exercise seems to be described in > 340175b7d14d5. setup_zone_pageset can check for an already allocated pcp > and simply reinitialize it. I meant this diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 754026a9164d..7169342f5474 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1810,7 +1818,6 @@ int __ref offline_pages(unsigned long start_pfn, unsigned long nr_pages) init_per_zone_wmark_min(); if (!populated_zone(zone)) { - zone_pcp_reset(zone); build_all_zonelists(NULL); } else zone_pcp_update(zone); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e6a602e82860..b0fdda77e570 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6496,7 +6496,13 @@ void __meminit setup_zone_pageset(struct zone *zone) struct per_cpu_pageset *p; int cpu; - zone->pageset = alloc_percpu(struct per_cpu_pageset); + /* + * zone could have gone completely offline during memory hotplug + * when the pgdat is left behind for simplicity. On a next onlining + * we do not need to reallocate pcp state. + */ + if (!zone->pageset) + zone->pageset = alloc_percpu(struct per_cpu_pageset); for_each_possible_cpu(cpu) { p = per_cpu_ptr(zone->pageset, cpu); pageset_init(p); @@ -8803,25 +8809,6 @@ void zone_pcp_enable(struct zone *zone) mutex_unlock(&pcp_batch_high_lock); } -void zone_pcp_reset(struct zone *zone) -{ - unsigned long flags; - int cpu; - struct per_cpu_pageset *pset; - - /* avoid races with drain_pages() */ - local_irq_save(flags); - if (zone->pageset != &boot_pageset) { - for_each_online_cpu(cpu) { - pset = per_cpu_ptr(zone->pageset, cpu); - drain_zonestat(zone, pset); - } - free_percpu(zone->pageset); - zone->pageset = &boot_pageset; - } - local_irq_restore(flags); -} - #ifdef CONFIG_MEMORY_HOTREMOVE /* * All pages in the range must be in a single zone, must not contain holes, -- Michal Hocko SUSE Labs