From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B507C433B4 for ; Tue, 20 Apr 2021 15:03:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E86C610CC for ; Tue, 20 Apr 2021 15:03:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E86C610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 055BA6B006C; Tue, 20 Apr 2021 11:03:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 005F76B006E; Tue, 20 Apr 2021 11:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1CF76B0071; Tue, 20 Apr 2021 11:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id C48F46B006C for ; Tue, 20 Apr 2021 11:03:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8A398441C for ; Tue, 20 Apr 2021 15:03:23 +0000 (UTC) X-FDA: 78053063886.08.82D7FE4 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 94EED40002E4 for ; Tue, 20 Apr 2021 15:03:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DB1B9610A1; Tue, 20 Apr 2021 15:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618930999; bh=j2AhiOXhAEFdSXlVtOmuTch74/ss0CH34AqlDj2lObw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rghGQ4Jms/10w+c2YUoA0xR7pEvFY+pxR5xN1nGHNOtIWuVhOZjS4OjDGWh0wTPzI RUuP17zgJlqsGRhFIpV2eRuid/0uqrYF74K5VpG4lVFZWkqrPIcbIkHikAMeITJKVU WhjGYkyswCKkggInHbmvW57ScJAZxQ3UUloLx6rEPnUsWD6H6pql50reuV5IONOLNM seMsNftgoixkTpCGEgvGDiOb+PlXgfV+0OMBu9tnscaCRp61/9BC0qt1zQ9w1w4Rdr 1n0zGLpmgjzZrjQpdUQCNSL1blMLFdzLl/ObWLC+ohd+RDp4p1ZkAn5AS3/acz9zlU /SNxFd6Pbb/Jg== Date: Tue, 20 Apr 2021 18:03:11 +0300 From: Mike Rapoport To: David Hildenbrand Cc: linux-arm-kernel@lists.infradead.org, Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 2/4] memblock: update initialization of reserved pages Message-ID: References: <20210420090925.7457-1-rppt@kernel.org> <20210420090925.7457-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 94EED40002E4 X-Stat-Signature: x5ib78eo693pm4mqbt4pyrt79gahcdyq Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618930999-572848 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 20, 2021 at 03:56:28PM +0200, David Hildenbrand wrote: > On 20.04.21 11:09, Mike Rapoport wrote: > > From: Mike Rapoport > > > > The struct pages representing a reserved memory region are initialized > > using reserve_bootmem_range() function. This function is called for each > > reserved region just before the memory is freed from memblock to the buddy > > page allocator. > > > > The struct pages for MEMBLOCK_NOMAP regions are kept with the default > > values set by the memory map initialization which makes it necessary to > > have a special treatment for such pages in pfn_valid() and > > pfn_valid_within(). > > Just a general question while thinking about it: > > Would we right now initialize the memmap of these pages already via > memmap_init_zone()->memmap_init_range()? (IOW, not marking the > PageReserved?) Yep. These pages are part of memblock.memory so they are initialized in memmap_init_zone()->memmap_init_range() to the default values. -- Sincerely yours, Mike.