From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E43C433ED for ; Tue, 20 Apr 2021 09:10:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49FE261354 for ; Tue, 20 Apr 2021 09:10:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49FE261354 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AC0E26B006E; Tue, 20 Apr 2021 05:10:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A711E6B0070; Tue, 20 Apr 2021 05:10:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 973DD6B0071; Tue, 20 Apr 2021 05:10:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 7B6B66B006E for ; Tue, 20 Apr 2021 05:10:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 31666181AEF09 for ; Tue, 20 Apr 2021 09:10:06 +0000 (UTC) X-FDA: 78052173612.26.B47F76A Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf10.hostedemail.com (Postfix) with ESMTP id 9FFBD40002D7 for ; Tue, 20 Apr 2021 09:09:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1618909804; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yjmwGXL95hrOTOiLoePNgjzr/aVIaC4rCsRgjXD+Ih4=; b=rQ4aiKfXozvbbX71hOvvbdh7Ca0q/3X063CDyFWMK+pX/uTOoCfeJ1dw6CL3KPUaYJJDBc xqg1B2H+sdQpK7GMFOqEDDuQWY3xyMmL+J/cjxDv9doDSJJbPAEuDgtxfXdJQ2Yf7BltJa R5NG9pJ01TsoDmtQyJJsZG3VQ7WBR8I= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 876CAAEE6; Tue, 20 Apr 2021 09:10:04 +0000 (UTC) Date: Tue, 20 Apr 2021 11:10:03 +0200 From: Michal Hocko To: Mike Rapoport Cc: Jonathan Corbet , Alexey Dobriyan , Andrew Morton , Mike Rapoport , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] docs: proc.rst: meminfo: briefly describe gaps in memory accounting Message-ID: References: <20210420085105.1156640-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210420085105.1156640-1-rppt@kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9FFBD40002D7 X-Stat-Signature: p4n1zae8oaiwaodftw8r91o3znhqe4pu Received-SPF: none (suse.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618909798-958484 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 20-04-21 11:51:05, Mike Rapoport wrote: > From: Mike Rapoport Some trivial changelog would be better than nothing. > Signed-off-by: Mike Rapoport But I do agree that this is a useful information to have in the documentation. Having networking counters as an example is helpful as well. I am not familiar with those myself much and I do remember there is much to it than just sockstat. It would be great to consult this with some networking expert and extend the documentation for that case which tends to be quite common AFAIK. Anyway this is already an improvement and a step into the right direction. Acked-by: Michal Hocko one nit below > --- > Documentation/filesystems/proc.rst | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 48fbfc336ebf..bf245151645b 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -929,8 +929,15 @@ meminfo > ~~~~~~~ > > Provides information about distribution and utilization of memory. This > -varies by architecture and compile options. The following is from a > -16GB PIII, which has highmem enabled. You may not have all of these fields. > +varies by architecture and compile options. Please note that is may happen that it may happen > +that the memory accounted here does not add up to the overall memory usage > +and the difference for some workloads can be substantial. In many cases > +there are other means to find out additional memory using subsystem > +specific interfaces, for instance /proc/net/sockstat for networking > +buffers. > + > +The following is from a 16GB PIII, which has highmem enabled. > +You may not have all of these fields. > > :: > > -- > 2.29.2 -- Michal Hocko SUSE Labs